Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimized env shim & support object.keys #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tada5hi
Copy link

@tada5hi tada5hi commented Feb 8, 2024

πŸ”— Linked issue

resolves #118

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@tada5hi
Copy link
Author

tada5hi commented Feb 13, 2024

@pi0 how can i help to move this forward ?

@pi0
Copy link
Member

pi0 commented Feb 13, 2024

Thanks for PR. It looks nice but too many changes in one PR that I need to carefully review. (https://github.com/pi0/tired-maintainer)

@tada5hi
Copy link
Author

tada5hi commented Feb 13, 2024

@pi0 you are very welcome ☺️✌️. I know you have much on your plate. This pr is also not urgent. So if I can help you any further or should adjust something, please let me know (ping me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Obect keys for env object
2 participants