Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delimiter based on the platform #176

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −2
Open

fix: delimiter based on the platform #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cb09b9
fix: delimiter based on the platform
malezjaa Jun 25, 2024
4af0ac5
fix: use globalThis
malezjaa Jun 26, 2024
0302126
fix: use globalThis for tests
malezjaa Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const _ROOT_FOLDER_RE = /^\/([A-Za-z]:)?$/;

// Force POSIX contants
export const sep = "/";
export const delimiter = ":";
export const delimiter = /^win/i.test(globalThis.process?.platform) ? ";" : ":";

// normalize
export const normalize: typeof path.normalize = function (path: string) {
Expand Down
4 changes: 3 additions & 1 deletion test/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,9 @@ runTest("toNamespacedPath", toNamespacedPath, {

describe("constants", () => {
it("delimiter should equal :", () => {
expect(delimiter).to.equal(":");
expect(delimiter).to.equal(
/^win/i.test(globalThis.process?.platform) ? ";" : ":",
);
});

it("sep should equal /", () => {
Expand Down