Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fetch): typed body/query options for $fetch #2405

Closed
wants to merge 3 commits into from

Conversation

DallasHoff
Copy link

πŸ”— Linked issue

#2244

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

These changes utilize the types exposed by the bodyValidator and queryValidator options added to h3 in unjs/h3#742 to add type safety to the body and query options of $fetch.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0
Copy link
Member

pi0 commented May 1, 2024

Hi and thanks for draft PR Since nitro is going through major refactors and h3 proposal is undergoing, I'm afraid this might get stalled. Also it is likely we move type support to ofetch (unjs/ofetch#371) so let's keep track proposal via unjs/h3#742 for now.

@pi0 pi0 closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants