Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: long lines and unnecessary scroll in code #79

Closed
wants to merge 2 commits into from

Conversation

@andreystepanov
Copy link
Contributor Author

To not limit wrapping of long lines only to literals (like bytes, text etc.) and make it more universal by applying styles on code .syntax.

I don't know where else code is used, so decided to apply styles only to span.syntax inside code. .syntax is added dynamically only when block is opened and full definition is shown to the user.

So this shouldn't break anything else.

@hojberg
Copy link
Member

hojberg commented Jan 29, 2024

Hmmm I'm not sure wrapping is the right solution. A horizontal scrollbar inside the code block is the "more true to the syntax rendering" way. I feel like I've fixed that like 5 times only for it to show up in a different form 😭

@hojberg
Copy link
Member

hojberg commented Mar 29, 2024

Thanks for looking into this @andreystepanov. I just merged #86 which fixes this without doing wrapping on the code.

@hojberg hojberg closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants