Update image builder doc for v2 #635
Open
+21
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Deploying docs with
|
| Latest commit: |
4164c14
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4cd3fbf3.docs-dog.pages.dev |
| Branch Preview URL: | https://enghabu-image-builder-v2.docs-dog.pages.dev |
kumare3
reviewed
Dec 31, 2025
| } | ||
| env = flyte.TaskEnvironment( | ||
| name="hello_v2", | ||
| image=flyte.Image.from_debian_base() |
Contributor
There was a problem hiding this comment.
I think you can do this
Suggested change
| image=flyte.Image.from_debian_base() | |
| image=flyte.Image.from_debian_base(name="private", registry="<my registry url>", registry_secret="My-secret") |
kumare3
reviewed
Dec 31, 2025
| env = flyte.TaskEnvironment( | ||
| name="hello_v2", | ||
| image=flyte.Image.from_debian_base() | ||
| .clone(registry="<my registry url>", name="private", registry_secret="GTEngHabu") |
Contributor
There was a problem hiding this comment.
And then drop this
Suggested change
| .clone(registry="<my registry url>", name="private", registry_secret="GTEngHabu") | |
Signed-off-by: Haytham Abuelfutuh <[email protected]>
kumare3
reviewed
Dec 31, 2025
| name="say-hello-image", | ||
| env = flyte.TaskEnvironment( | ||
| name="hello_v2", | ||
| image=flyte.Image.from_debian_base() |
Contributor
Author
There was a problem hiding this comment.
ah, I didn't even want to show secret here... removed this line, will this work?
Signed-off-by: Haytham Abuelfutuh <[email protected]>
kumare3
approved these changes
Dec 31, 2025
pingsutw
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haytham Abuelfutuh [email protected]