Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and add notes about the hardware acceleration with KVM for random number generation #405

Closed
wants to merge 6 commits into from

Conversation

huyang531
Copy link
Contributor

@huyang531 huyang531 commented Mar 24, 2024

Two changes are introduced in this PR:

  1. Fix a few typos in build-process.mdx and index.mdx
  2. Add notes about hardware acceleration with KVM for random number generating since Unkiraft v0.17.0, which in my case, meant that two additional flags are needed when running the image on a x86_64 platform with KVM support.

Signed-off-by: Yang Hu [email protected]

@huyang531 huyang531 changed the title Fix typos in build-process.mdx and index.mdx Fix typos and add notes about the hardware acceleration with KVM for random number generation Jun 17, 2024
@huyang531 huyang531 marked this pull request as draft June 17, 2024 01:28
@razvand razvand requested a review from StefanJum August 19, 2024 10:22
@razvand razvand self-assigned this Aug 19, 2024
@razvand razvand added the enhancement New feature or request label Aug 19, 2024
@razvand razvand marked this pull request as ready for review August 19, 2024 10:22
@StefanJum
Copy link
Member

@huyang531 Please do not use merge commits, and use the same naming conventions for all of them (either (fix... or selctor/component:....).

@huyang531
Copy link
Contributor Author

@huyang531 Please do not use merge commits, and use the same naming conventions for all of them (either (fix... or selctor/component:....).

I have no idea what I was doing. Please see PR #452 instead.

@huyang531 huyang531 closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants