-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/getting-started: Added FreeBSD sed debug note. #226
Open
dondavan
wants to merge
7
commits into
unikraft:main
Choose a base branch
from
dondavan:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug occurs when I'm following intrutions from getting-started page to build Unikraft through Makefile, when executing make menuconfig: thhugh@sp-eduroam-192-119 app-helloworld % make menuconfig make[1]: Entering directory '/Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft' sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE Makefile:516: *** Target architecture () is currently not supported (could not find /Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft/arch///Makefile.uk).. Stop. make[1]: Leaving directory '/Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft' make: *** [Makefile:9: menuconfig] Error 2 This happened when unikraft/Makefile use sed to match host device architecture. My device: OS X Monterey, Version 12.5.1. And I got no problem into config menu in my VM, problem was located in different version of sed. Where OS X default uses OpenBSD sed caused problem, and GNU sed have no issues. So brew installed GNU sed and export to PATH, replaced OpenBSD sed, bug solved, no problem entering config menu. Suggested solution tested. Consider this problem is platfrom specific, so no change made in Makefile but add note at original page. Signed-off-by: Hugh Xu <[email protected]>
A bug occurs when I'm following intrutions from getting-started page to build Unikraft through Makefile, when executing make menuconfig: thhugh@sp-eduroam-192-119 app-helloworld % make menuconfig make[1]: Entering directory '/Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft' sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE Makefile:516: *** Target architecture () is currently not supported (could not find /Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft/arch///Makefile.uk).. Stop. make[1]: Leaving directory '/Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft' make: *** [Makefile:9: menuconfig] Error 2 This happened when unikraft/Makefile use sed to match host device architecture. My device: OS X Monterey, Version 12.5.1. And I got no problem into config menu in my VM, problem was located in different version of sed. Where OS X default uses OpenBSD sed caused problem, and GNU sed have no issues. So brew installed GNU sed and export to PATH, replaced OpenBSD sed, bug solved, no problem entering config menu. Suggested solution tested. Consider this problem is platfrom specific, so no change made in Makefile but add note at original page. Signed-off-by: Hugh Xu <[email protected]>
A bug occurs when I'm following intrutions from getting-started page to build Unikraft through Makefile, when executing make menuconfig: thhugh@sp-eduroam-192-119 app-helloworld % make menuconfig make[1]: Entering directory '/Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft' sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE sed: 1: stdin: \1 not defined in the RE Makefile:516: *** Target architecture () is currently not supported (could not find /Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft/arch///Makefile.uk).. Stop. make[1]: Leaving directory '/Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft' make: *** [Makefile:9: menuconfig] Error 2 This happened when unikraft/Makefile use sed to match host device architecture. My device: OS X Monterey, Version 12.5.1. And I got no problem into config menu in my VM, problem was located in different version of sed. Where OS X default uses OpenBSD sed caused problem, and GNU sed have no issues. So brew installed GNU sed and export to PATH, replaced OpenBSD sed, bug solved, no problem entering config menu. Suggested solution tested. Consider this problem is platfrom specific, so no change made in Makefile but add note at original page. Signed-off-by: Hugh Xu <[email protected]>
StefanJum
requested changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dondavan , could you please see @StefanJum 's comments and rebase the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug occurs when I'm following intrutions from getting-started page to build Unikraft through Makefile, when executing make menuconfig:
thhugh@sp-eduroam-192-119 app-helloworld % make menuconfig
make[1]: Entering directory '/Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft'
sed: 1: stdin: \1 not defined in the RE
sed: 1: stdin: \1 not defined in the RE
sed: 1: stdin: \1 not defined in the RE
sed: 1: stdin: \1 not defined in the RE
sed: 1: stdin: \1 not defined in the RE
sed: 1: stdin: \1 not defined in the RE
sed: 1: stdin: \1 not defined in the RE
Makefile:516: *** Target architecture () is currently not supported (could not find /Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft/arch///Makefile.uk).. Stop.
make[1]: Leaving directory '/Users/thhugh/Desktop/Unikraft/my-unikernel/unikraft'
make: *** [Makefile:9: menuconfig] Error 2
This happened when unikraft/Makefile use sed to match host device architecture.
My device:
OS X Monterey, Version 12.5.1.
And I got no problem into config menu in my VM, problem was located in different version of sed.
Where OS X default uses OpenBSD sed caused problem, and GNU sed have no issues.
So brew installed GNU sed and export to PATH, replaced OpenBSD sed, bug solved, no problem entering config menu.
Suggested solution tested.
Consider this problem is platfrom specific, so no change made in Makefile but add note at original page.
Signed-off-by: Hugh Xu [email protected]