ICU-22872 Fix BigDecimal scale in DecimalFormat.parse()#3853
Open
aryanraj45 wants to merge 1 commit intounicode-org:mainfrom
Open
ICU-22872 Fix BigDecimal scale in DecimalFormat.parse()#3853aryanraj45 wants to merge 1 commit intounicode-org:mainfrom
aryanraj45 wants to merge 1 commit intounicode-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix BigDecimal scale preservation in DecimalFormat.parse()
Root cause: The internal BCD (Binary Coded Decimal) representation doesn't store trailing zeros. When parsing decimal numbers like "0.0" or "1.00", the BigDecimal scale was incorrectly set to 0 instead of preserving the number of decimal places from the input string.
Solution:
fractionDigitCountfield toParsedNumberto track the number of digits after the decimal point during parsinggetNumber()to apply the correct scale to the resulting BigDecimal when it would otherwise be too smallChanges:
ParsedNumber.java: Added fractionDigitCount field and scale adjustment logic in getNumber()DecimalMatcher.java: Set fractionDigitCount when decimal separator is encounteredNumberFormatTest.java: Added TestParseBigDecimalScale test case covering inputs like "0.0", "1.00", "123.450"Testing:
Related: https://github.com/unicode-org/icu/blob/main/CONTRIBUTING.md
Checklist