Require Range to be a range in UTFStringCodePoints to improve error messages#3733
Draft
eggrobin wants to merge 3 commits intounicode-org:mainfrom
Draft
Require Range to be a range in UTFStringCodePoints to improve error messages#3733eggrobin wants to merge 3 commits intounicode-org:mainfrom
eggrobin wants to merge 3 commits intounicode-org:mainfrom
Conversation
Member
Author
|
@markusicu, should this target main on a new ticket, or 78 maintenance on a reopened ICU-23004? |
jmr
reviewed
Oct 22, 2025
Member
@eggrobin is this PR fixing problems, or just "improv[ing] error messages"? @mihnita @richgillam FYI |
markusicu
reviewed
Oct 23, 2025
Member
markusicu
left a comment
There was a problem hiding this comment.
lgtm as an improvement for ICU 79 -- please create an ICU 79 ticket for such improvements
markusicu
reviewed
Nov 11, 2025
Member
markusicu
left a comment
There was a problem hiding this comment.
please create an ICU 79 ticket for this
| */ | ||
| template<typename CP32, UTFIllFormedBehavior behavior, typename Range> | ||
| #if defined(__cpp_lib_ranges) | ||
| requires std::ranges::range<Range> |
Member
There was a problem hiding this comment.
Suggested change
| requires std::ranges::range<Range> | |
| requires std::ranges::range<Range> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by @jmr after seeing the error messages generated by
UTFStringCodePoints<..., char>(which was how this API worked in an earlier draft).TODO: Fill out the checklist below.
Checklist