Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2340] Remove Content-Length header when request is deflated. #1548

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2340] Remove Content-Length header when request is deflated. #1548

wants to merge 1 commit into from

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Feb 9, 2024

Issue: https://issues.redhat.com/browse/UNDERTOW-2340

This needs review. Possibly change to Partial receive methods?

@fl4via fl4via added bug fix Contains bug fix(es) under verification Currently being verified (running tests, reviewing) before posting a review to contributor labels Feb 12, 2024
@baranowb baranowb requested review from ropalka and fl4via June 24, 2024 13:00
ropalka
ropalka requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update minor issue with Copyright year, otherwise looks good to me.

core/src/test/java/io/undertow/server/handlers/encoding/RequestContentEncodingTestCase2.java Outdated Show resolved Hide resolved
core/src/test/java/io/undertow/server/handlers/encoding/RequestContentEncodingTestCase3.java Outdated Show resolved Hide resolved
core/src/test/java/io/undertow/server/handlers/encoding/RequestContentEncodingTestCase4.java Outdated Show resolved Hide resolved
@baranowb baranowb removed the under verification Currently being verified (running tests, reviewing) before posting a review to contributor label Jun 26, 2024
@baranowb baranowb self-assigned this Jun 26, 2024
@baranowb baranowb added the next release This PR will be merged before next release or has already been merged (for payload double check) label Jun 26, 2024
@baranowb baranowb added waiting peer review PRs that edit core classes might require an extra review and removed next release This PR will be merged before next release or has already been merged (for payload double check) labels Jul 30, 2024
@baranowb baranowb added the under verification Currently being verified (running tests, reviewing) before posting a review to contributor label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka approved these changes

@fl4via fl4via Awaiting requested review from fl4via

@jasondlee jasondlee Awaiting requested review from jasondlee

Assignees

@baranowb baranowb

Labels
bug fix Contains bug fix(es) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baranowb @ropalka @fl4via