fix(preset-vue): yarn mode webpack require hook is invalid #12653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
xierenyuan
commented
Aug 20, 2024
| @@ -23,6 +22,8 @@ export function getConfig(config: Config, api: IApi) { | |||
| babelParserPlugins: ['jsx', 'classProperties', 'decorators-legacy'], | |||
| }); | |||
|
|
|||
| const VueLoaderPlugin = require('vue-loader/dist/pluginWebpack5'); | |||
There was a problem hiding this comment.
修复移除 requireHook 导致的 vite 失败
|
Size Change: +2 B (0%) Total Size: 9.94 MB
ℹ️ View Unchanged
|
xierenyuan
commented
Aug 20, 2024
| @@ -25,7 +25,7 @@ export default (function target(userConfig) { | |||
| return false; | |||
| } | |||
|
|
|||
| const isLegacy = isLegacyBrowser(userConfig.targets); | |||
| const isLegacy = isLegacyBrowser(userConfig.targets || {}); | |||
There was a problem hiding this comment.
targets 为空时 Object.keys 有问题
sorrycc
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复社区反馈的 requireHook 调整导致的 yarn 安装依赖 vue webpack requireHook 失败
同时修复 vite targets 为空的情况