-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disableDayjsAlias should be default value of antd.momentPicker #12530
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Walkthrough这个更改涉及在 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/plugins/src/antd.ts (1 hunks)
Additional comments not posted (1)
packages/plugins/src/antd.ts (1)
228-228
: 变更已批准,但请验证disableDayjsAlias
的使用。此更改确保
AntdMomentWebpackPlugin
配置了disableDayjsAlias
选项,符合 PR 目标。请确保在代码库中正确使用了
disableDayjsAlias
选项。Verification successful
变更已批准,
disableDayjsAlias
选项的使用已验证。此更改确保
AntdMomentWebpackPlugin
配置了disableDayjsAlias
选项,并且在代码库中没有其他使用。Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `disableDayjsAlias` in the codebase. # Test: Search for the usage of `disableDayjsAlias`. Expect: Only occurances of the new configuration. rg --type js --type ts $'disableDayjsAlias'Length of output: 184
Co-authored-by: Sakina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/plugins/src/antd.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/plugins/src/antd.ts
see ant-design/antd-moment-webpack-plugin#4
Summary by CodeRabbit
AntdMomentWebpackPlugin
的使用方式,添加disableDayjsAlias: true
配置,以提高插件兼容性。