Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disableDayjsAlias should be default value of antd.momentPicker #12530

Closed
wants to merge 2 commits into from

Conversation

afc163
Copy link
Contributor

@afc163 afc163 commented Jul 4, 2024

see ant-design/antd-moment-webpack-plugin#4

Summary by CodeRabbit

  • 优化
    • 修改 AntdMomentWebpackPlugin 的使用方式,添加 disableDayjsAlias: true 配置,以提高插件兼容性。

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Jul 4, 2024 7:49am

Copy link

coderabbitai bot commented Jul 4, 2024

Walkthrough

这个更改涉及在 antd.ts 文件中调整 AntdMomentWebpackPlugin 的使用方式。在 api.chainWebpack 函数内创建 AntdMomentWebpackPlugin 实例时,传递了一个包含 disableDayjsAlias 属性设置为 true 的对象。这种更改旨在禁用 Day.js 的别名使用,从而确保与 Moment.js 的兼容性。

Changes

文件路径 变更摘要
packages/plugins/src/antd.ts 修改 AntdMomentWebpackPlugin 的使用方式,传递 disableDayjsAlias 属性为 true 的对象。

Poem

啊,插件更新多简洁,

Moment 竟与 Day.js 别,

新增属性解纷争,

编码愉快又顺心。🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c0da93f and afaf371.

Files selected for processing (1)
  • packages/plugins/src/antd.ts (1 hunks)
Additional comments not posted (1)
packages/plugins/src/antd.ts (1)

228-228: 变更已批准,但请验证 disableDayjsAlias 的使用。

此更改确保 AntdMomentWebpackPlugin 配置了 disableDayjsAlias 选项,符合 PR 目标。

请确保在代码库中正确使用了 disableDayjsAlias 选项。

Verification successful

变更已批准,disableDayjsAlias 选项的使用已验证。

此更改确保 AntdMomentWebpackPlugin 配置了 disableDayjsAlias 选项,并且在代码库中没有其他使用。

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `disableDayjsAlias` in the codebase.

# Test: Search for the usage of `disableDayjsAlias`. Expect: Only occurances of the new configuration.
rg --type js --type ts $'disableDayjsAlias'

Length of output: 184

packages/plugins/src/antd.ts Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between afaf371 and 67975a3.

Files selected for processing (1)
  • packages/plugins/src/antd.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/plugins/src/antd.ts

@afc163 afc163 marked this pull request as draft July 4, 2024 10:02
@afc163 afc163 closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants