feat(preset-umi): throw by default when pre-render error #11521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #11521 +/- ##
==========================================
- Coverage 29.03% 29.02% -0.01%
==========================================
Files 484 484
Lines 14701 14705 +4
Branches 3473 3475 +2
==========================================
Hits 4268 4268
- Misses 9678 9681 +3
- Partials 755 756 +1
☔ View full report in Codecov by Sentry. |
PeachScript
changed the title
PeachScript
changed the title
fz6m
reviewed
Aug 16, 2023
| @@ -58,6 +58,9 @@ function getExportHtmlData(routes: Record<string, IRoute>): IExportHtmlItem[] { | |||
| * get pre-rendered html by route path | |||
| */ | |||
| async function getPreRenderedHTML(api: IApi, htmlTpl: string, path: string) { | |||
| const { | |||
| exportStatic: { ignorePreRenderError = false }, | |||
There was a problem hiding this comment.
下面还有一个 api.config.mountElementId ，所有的属性解构应该放在一起。
| @@ -82,6 +85,9 @@ async function getPreRenderedHTML(api: IApi, htmlTpl: string, path: string) { | |||
| logger.info(`Pre-render for ${path}`); | |||
| } catch (err) { | |||
| logger.error(`Pre-render ${path} error: ${err}`); | |||
| if (!ignorePreRenderError) { | |||
| throw err; | |||
There was a problem hiding this comment.
throw new Error('Pre render error', { cause: err })
fz6m
reviewed
Aug 16, 2023
| @@ -654,6 +654,17 @@ export default { | |||
| } | |||
| ``` | |||
|
|
|||
| `exportStatic` 在搭配 `ssr` 使用时会进行预渲染，在预渲染失败时会抛出异常并终止构建，可以通过配置 `ignorePreRenderError` 来忽略预渲染失败的错误，例如： | |||
There was a problem hiding this comment.
- `exportStatic` 在搭配 `ssr` 使用时会进行预渲染，在预渲染失败时会抛出异常并终止构建，可以通过配置 `ignorePreRenderError` 来忽略预渲染失败的错误，例如：
+ `exportStatic` 在搭配 `ssr` 使用时会进行预渲染，默认在预渲染失败时会抛出异常并终止构建，通过配置 `ignorePreRenderError` 来忽略预渲染异常报错，例如：
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
现在 Pre-render 失败时仍会跑完整个构建，用户不注意的话就不会发现有编译问题。
Solution
exportStatic.ignorePreRenderError配置，开启后会和以前的行为一样