-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Examine 3.4.0 #17367
base: contrib
Are you sure you want to change the base?
Update to Examine 3.4.0 #17367
Conversation
Hi there @Shazwazza, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
@Shazwazza it seems you forgot to update |
@bjarnef thanks, have updated |
Hi.. I have updated for v15 as part of a bigger nuget update PR (#17370). One thing I noticed, is that we suddenly get exceptions when disposing, because something was already disposed. I'm afraid it will break peoples solutions, if we update on v13 and v14 |
@bergmania do you have a stack trace or steps to replicate and then I can fix up. |
@Shazwazza, the test suites exploded, but I do not have the stacktrace at hand anymore. I had to make this change: |
Prerequisites
If there's an existing issue for this PR then this fixes
Description
Update to Examine 3.4.0, see release notes here https://github.com/Shazwazza/Examine/releases/tag/v3.4.0