Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Examine 3.4.0 #17367

Open
wants to merge 4 commits into
base: contrib
Choose a base branch
from
Open

Update to Examine 3.4.0 #17367

wants to merge 4 commits into from

Conversation

Shazwazza
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

Update to Examine 3.4.0, see release notes here https://github.com/Shazwazza/Examine/releases/tag/v3.4.0

Copy link

Hi there @Shazwazza, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef
Copy link
Contributor

bjarnef commented Oct 25, 2024

@Shazwazza it seems you forgot to update Examine.Core reference as well.

Directory.Packages.props Outdated Show resolved Hide resolved
@Shazwazza
Copy link
Contributor Author

@bjarnef thanks, have updated

@bergmania
Copy link
Member

bergmania commented Nov 3, 2024

Hi.. I have updated for v15 as part of a bigger nuget update PR (#17370).

One thing I noticed, is that we suddenly get exceptions when disposing, because something was already disposed. I'm afraid it will break peoples solutions, if we update on v13 and v14

@Shazwazza
Copy link
Contributor Author

@bergmania do you have a stack trace or steps to replicate and then I can fix up.

@bergmania
Copy link
Member

bergmania commented Nov 3, 2024

@Shazwazza, the test suites exploded, but I do not have the stacktrace at hand anymore.

I had to make this change:
https://github.com/umbraco/Umbraco-CMS/pull/17370/files#diff-77a94f4ca225bfcb32a30bef1ce75e54dbb570a693368bbf4ae64426ccd2205cR51-R58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants