Determine urls at save and publish time #17033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/determine-urls-at-publish-time
…eature/determine-urls-at-publish-time # Conflicts: # src/Umbraco.Web.UI.Client
…eature/determine-urls-at-publish-time
…eature/determine-urls-at-publish-time # Conflicts: # src/Umbraco.Web.UI.Client
…-3gvx/v14/dev' into v14/feature/determine-urls-at-publish-time # Conflicts: # src/Umbraco.Web.UI.Client
…eature/determine-urls-at-publish-time
…eature/determine-urls-at-publish-time # Conflicts: # src/Umbraco.Core/DependencyInjection/UmbracoBuilder.cs # src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs # src/Umbraco.Web.UI.Client
…blish-time' into v15/feature/determine-urls-at-save-and-publish-time # Conflicts: # src/Umbraco.Web.UI.Client
…eature/determine-urls-at-save-and-publish-time # Conflicts: # global.json
…ine-urls-at-save-and-publish-time # Conflicts: # src/Umbraco.Web.UI.Client
…ine-urls-at-save-and-publish-time
…ine-urls-at-save-and-publish-time
…ine-urls-at-save-and-publish-time
…ine-urls-at-save-and-publish-time
…ine-urls-at-save-and-publish-time # Conflicts: # src/Umbraco.Web.UI.Client
…ine-urls-at-save-and-publish-time # Conflicts: # src/Umbraco.Web.UI.Client
…ine-urls-at-save-and-publish-time # Conflicts: # src/Umbraco.Web.UI.Client
…ine-urls-at-save-and-publish-time # Conflicts: # src/Umbraco.Core/Services/ContentService.cs # src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPremigrationPlan.cs # src/Umbraco.Web.UI.Client
…ine-urls-at-save-and-publish-time # Conflicts: # src/Umbraco.Web.UI.Client
…ine-urls-at-save-and-publish-time
nikolajlauridsen
deleted the
v15/feature/determine-urls-at-save-and-publish-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new content finder that finds content by url, but the urls are persisted on save/publish time instead of determined on runtime using NuCache.
Details
A new
IDocumentUrlServicehas been introduced. It keeps an local cache with all url segments, that is seeded on boot. To insure this, aDocumentUrlServiceInitializerhas been introduced, that executes on boot as a hosted service. It checks if the all urls needs to be rebuilt, in caches where theUrlSegmentProviderCollectionhas changed. Otherwise it just loads in the urls from the database.The document urls are updated using the
ContentCacheRefresherto ensure updates happens on all servers.When the content finder is used, it rely on the
IDocumentNavigationQueryServiceto navigate the ancestors. This is only intended to happen from the website-serveres. There is also a method to get all urls for a given content Id. This is intended to be used from backoffice, and do not rely onIDocumentNavigationQueryService.For the database, I had to introduce a new index type, that we have not used before The Unique Clusted index.
Test
umbracoUrlNameproperty name that will override the name when generating the url segment