Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ultralytics Actions with OpenAI GPT-4 PR Summary #77

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Ultralytics Actions with OpenAI GPT-4 PR Summary #77

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d94a9e2
Update Ultralytics Actions
pderrenger Jan 28, 2024
37a7a1b
Update format.yml
glenn-jocher Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name: Ultralytics Actions
on:
push:
branches: [main,master]
pull_request_target:
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (llm): Changing from pull_request_target to pull_request alters the permissions and event context. Ensure that this change doesn't introduce any security vulnerabilities, especially if the workflow uses the GITHUB_TOKEN or other secrets in the context of a pull request from a fork.

branches: [main,master]

jobs:
Expand All @@ -17,9 +17,11 @@ jobs:
- name: Run Ultralytics Formatting
uses: ultralytics/actions@main
with:
token: ${{ secrets.GITHUB_TOKEN }} # automatically generated
python: true
docstrings: true
markdown: true
spelling: true
links: true
token: ${{ secrets.GITHUB_TOKEN }} # automatically generated, do not modify
python: true # format Python code and docstrings
markdown: true # format Markdown and YAML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): The comment '# format Markdown and YAML' might be misleading as the option name 'markdown' suggests it's only for Markdown. If it indeed formats YAML, consider renaming the option to reflect both formats or updating the comment to avoid confusion.

spelling: true # check spelling
links: true # check broken links
summary: true # print PR summary with GPT4 (requires 'openai_api_key' or 'openai_azure_api_key' and 'openai_azure_endpoint')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (llm): The addition of GPT-4 summary generation is an interesting feature. However, it's important to consider the potential costs associated with the OpenAI API usage and ensure that there are checks in place to prevent abuse or excessive use.

openai_azure_api_key: ${{ secrets.OPENAI_AZURE_API_KEY }}
openai_azure_endpoint: ${{ secrets.OPENAI_AZURE_ENDPOINT }}
Loading