DST-950: initial trio of views #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 24, 2025 15:17
chris-pettinga
requested changes
Jan 30, 2025
Comment on lines
137
to
138
| licence_id = self.request.session["licence_id"] | ||
| licence_object = Licence.objects.get(pk=licence_id) |
There was a problem hiding this comment.
this logic I think is shared between a bunch of views and could potentially be abstracted to a get_object() method as part of a DetailView because that's kind of what we're doing. It will also allow us a single place these objects are retrieved which means we can easily put security controls in place to make sure you only see the Licence objects that you have access to
Comment on lines
28
to
30
| individual_id = self.kwargs.get("individual_uuid") | ||
| licence_id = self.request.session["licence_id"] | ||
| licence_object = get_object_or_404(Licence, pk=licence_id) |
There was a problem hiding this comment.
Yeah I think most of these views are really actually DetailViews, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the following views to save and return:
Frontend tests are failing due to the CYA pages but this will be addressed in https://uktrade.atlassian.net/browse/DST-952