Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DBTP-1507 Setup codepipeline notifications #314

Draft
wants to merge 95 commits into
base: main
Choose a base branch
from

Conversation

tony-griffin
Copy link
Contributor

@tony-griffin tony-griffin commented Jan 16, 2025

Addresses DBTP-1507

Use platform-helper notify commands for notifications, similar to our other pipelines.

Screenshot 2025-01-17 at 12 14 18 Screenshot 2025-01-17 at 12 17 28 Screenshot 2025-01-17 at 12 18 37 Screenshot 2025-01-17 at 12 23 54 Screenshot 2025-01-17 at 12 29 57

Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

JohnStainsby and others added 26 commits December 17, 2024 15:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.56%. Comparing base (cbad429) to head (26d8ebf).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ipelines/custom_pipeline_update/update_pipeline.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   80.83%   81.56%   +0.72%     
==========================================
  Files           5        7       +2     
  Lines         814      857      +43     
==========================================
+ Hits          658      699      +41     
- Misses        156      158       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants