Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DBTP-1568 - Add s3 support for cross environment service access #293

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ksugden
Copy link
Contributor

@ksugden ksugden commented Nov 21, 2024

Addresses DBTP-1568

Adds cross environment support by giving access to a task role in a different account to an S3 bucket when the relevant config is provided.

Example platform-config.yml:

...
     hotfix:
        bucket_name: x-account-bucket
        versioning: false

        cross_environment_service_access:
          e2e_test_permissions:
            application: demodjango
            environment: test-env
            account: "12334556"
            service: web
            read: true
            write: true
            cyber_sign_off_by: [email protected]

Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@ksugden ksugden changed the title Dbtp 1568 s3 cross env service access feat: DBTP-1568 - Add s3 support for cross environment service access Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (795dbae) to head (e2aa405).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #293   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           50        50           
=========================================
  Hits            50        50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antroy-madetech antroy-madetech marked this pull request as ready for review December 12, 2024 16:10
@antroy-madetech antroy-madetech requested a review from a team as a code owner December 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants