Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1625 Measure conditions and footnotes not showing on review measures #1366

Merged

Conversation

mattjamc
Copy link
Collaborator

@mattjamc mattjamc commented Dec 19, 2024

TP2000-1625 Measure conditions and footnotes not showing on review measures

Why

HMRC users noticed they could not see conditions and footnotes on measures in workbasket 2020.

This was because it was filtering current conditions by current workbasket rather than the workbasket they were viewing.

What

This PR:

  • Updates conditions_list macro so that it takes a workbasket argument. This allows specification of whether the current conditions should be queried in the current workbasket or another one (in this case if you're reviewing measures in workbasket X, workbasket X will not necessarily be your current workbasket)
  • passes workbasket argument in places conditions_list is used - that is, review measures tab, measures search and worksheet checker

@mattjamc mattjamc marked this pull request as ready for review December 19, 2024 13:35
@mattjamc mattjamc requested a review from a team as a code owner December 19, 2024 13:35
@mattjamc mattjamc merged commit d727039 into master Jan 2, 2025
8 checks passed
@mattjamc mattjamc deleted the TP2000-1625-Measure-conditions-not-showing-on-review-measures branch January 2, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants