Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug grtlv 404 caching issue on logged out learn articles and hcsat #3641

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

FoxJamie16
Copy link
Contributor

What

<What is this PR doing, e.g. implementations, algorithms, etc.?>

Why

<Why is this change happening, e.g. goals, use cases, stories, etc.?>

Tick or delete as appropriate:

Workflow

Reviewing help

  • Explains how to test locally, including how to set up appropriate data
  • Includes screenshot(s) - ideally before and after, but at least after
  • Documentation has been updated as necessary
  • Where a PR contains code changes developed or maintained by multiple squads a representative from those squads should review the PR.

Housekeeping

  • Added all new environment variables to Vault.
  • Cleaned up old feature flags
  • Upgraded any vulnerable dependencies.
  • I have updated security dependencies
  • Python requirements have been re-compiled.
  • I have checked that my PR is using the latest package versions of: great-components, directory-constants, directory-healthcheck, directory-validators, directory-components, directory-api-client, directory-ch-client, django-staff-sso-client, directory-forms-api-client, directory-sso-api-client, sigauth

Security

  • Frontend assets have been re-compiled
  • Checked for potential security vulnerabilities
  • Ensured any sensitive data is handled appropriately

Performance

  • Evaluated the performance impact of the changes
  • Ensured that changes do not negatively affect application scalability.

Merging

  • This PR can be merged by reviewers. (If unticked, please leave for the author to merge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant