Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ET-65 market standardisation #1253

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

TOE703
Copy link
Contributor

@TOE703 TOE703 commented Apr 24, 2024

Add model, task, source data to import data for markets

Workflow

Reviewing help

  • Explains how to test locally, including how to set up appropriate data

Merging

  • This PR can be merged by reviewers. (If unticked, please leave for the author to merge)

Sorry, something went wrong.

@TOE703 TOE703 requested a review from a team as a code owner April 24, 2024 11:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 91.13924% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 97.46%. Comparing base (9c9351d) to head (c80ad31).

Files Patch % Lines
...t/commands/import_markets_countries_territories.py 92.30% 4 Missing ⚠️
dataservices/views.py 66.66% 2 Missing ⚠️
dataservices/models.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1253      +/-   ##
===========================================
- Coverage    97.56%   97.46%   -0.11%     
===========================================
  Files          135      136       +1     
  Lines         4965     5044      +79     
===========================================
+ Hits          4844     4916      +72     
- Misses         121      128       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TOE703 TOE703 force-pushed the ET-65-market-standardisation branch from 352edb2 to 66e0db1 Compare April 25, 2024 14:59
Copy link
Contributor

@ecbm ecbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lewis-coulson-dit lewis-coulson-dit merged commit 102095b into develop Apr 29, 2024
5 checks passed
@TOE703 TOE703 deleted the ET-65-market-standardisation branch April 29, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants