UAT / PROD release #1239
Merged
UAT / PROD release #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greatuk 101 automate IMF data
…ge-black GREATUK-440 Fix Black vulnerable to Regular Expression Denial of Service
Bump django to 4.2.11
sebs-code
reviewed
Apr 2, 2024
| help='Store dataset records', | ||
| ) | ||
|
|
||
| def load_data(self): | ||
| data = [] | ||
| chunks = pd.read_sql(sa.text(self.sql), self.engine, chunksize=10000) |
There was a problem hiding this comment.
It looks like the self.engine (sqlachemy engine) is still being passed in here, yet has been deleted? (line 12). Does it already exists in the MarketGuidesDataIngestionCommand parent class?
There was a problem hiding this comment.
Have just checked - yes it does. Please ignore.
sebs-code
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UAT / PROD release