Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greatuk 101 automate IMF data #1234

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Conversation

bobby-didcoding
Copy link
Contributor

@bobby-didcoding bobby-didcoding commented Mar 18, 2024

This PR is to automate the import_world_economic_outlook_data management command and run it alongside the 3 x commands in the main pipeline.

To test locally you need to activate a tunnel to an env of your choice...Lets use staging

Note: you won't be able to test his if you use a docker set up

  1. login to cf with: cf login -sso
  2. select > org: dit-staging
  3. select > space: directory-staging
  4. create tunnel: cf ssh directory-api-staging -T -L 12345:data-workspace-datasets-for-great-staging.apps.internal:5432
  5. run management command from a new terminal: python manage.py import_world_economic_outlook_data
  6. You should see 'Would create 26166 records' if it worked correctly

Workflow

Reviewing help

  • Explains how to test locally, including how to set up appropriate data

Merging

  • This PR can be merged by reviewers.

@bobby-didcoding bobby-didcoding requested a review from a team as a code owner March 18, 2024 14:51
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (5ed7e74) to head (8a36fa3).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1234      +/-   ##
===========================================
- Coverage    97.54%   97.54%   -0.01%     
===========================================
  Files          134      134              
  Lines         4922     4920       -2     
===========================================
- Hits          4801     4799       -2     
  Misses         121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobby-didcoding bobby-didcoding merged commit 41cd421 into develop Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants