WIP: Clean user records #482
Draft
+183
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamLamb
reviewed
Oct 19, 2023
| @@ -783,6 +783,10 @@ def save(self, *args, **kwargs): | |||
| from peoplefinder.services.person import PersonService | |||
|
|
|||
| self.profile_completion = PersonService().get_profile_completion(person=self) | |||
|
|
|||
| if self.user and self.is_active != self.user.is_active: | |||
| self.user.is_active = self.is_active | |||
There was a problem hiding this comment.
If the profile is set to active and the user is set to inactive, it will update the user to be active, is this the desired behaviour?
Is there any way that updates the User is active flag? (maybe from SSO?)
There was a problem hiding this comment.
I put this as provocation - my assumption is whichever record (User / Person) is being saved, you probably want the other record's is_active to match.... ?
There was a problem hiding this comment.
the sso connection is waiting on a erlated PR but is there in the management command; I could abstract this to a service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made a management command that will:
made another management command that will:
Amended the active/inactive setters in the codebase (inc admin) to make sure they stay in sync