feat/avoid creation of duplicate quicksight users #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was already borderline overcomplicated before - there wasn't and isn't a need for this since view permissions for dashboards are all managed from inside Data Workspace
michalc
force-pushed
the
feat/remove-duplicate-quicksight-accounts
branch
from
c0b9b93 to
6048648
Compare
JosefSmith
force-pushed
the
feat/remove-duplicate-quicksight-accounts
branch
2 times, most recently
from
72ad294 to
46319a7
Compare
JosefSmith
force-pushed
the
feat/remove-duplicate-quicksight-accounts
branch
from
46319a7 to
c095aff
Compare
JosefSmith
changed the title
JosefSmith
force-pushed
the
feat/remove-duplicate-quicksight-accounts
branch
from
091940b to
4f5dd5e
Compare
JosefSmith
force-pushed
the
feat/remove-duplicate-quicksight-accounts
branch
from
4f5dd5e to
d42fa5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Previously, users viewing quicksight visualisations would create a "READER" user, whilst changing them would create an "AUTHOR" user, resulting in some confusion when giving users access. With this PR, viewing a quicksight visualisation should now be use an anonymous user, with a URL which is valid for 5 minutes.
Checklist