fix: return None if no pipeline state is found (#2823)

uktrade · Oct 24, 2023 · b87a984 · b87a984
1 parent 26e57d8
commit b87a984
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/dataworkspace/dataworkspace/apps/datasets/models.py b/dataworkspace/dataworkspace/apps/datasets/models.py
@@ -897,6 +897,10 @@ def get_pipeline_last_success_date(self):
             return None
         return get_pipeline_last_success_date(pipeline_name)
 
+    def pipeline_last_run_success(self):
+        last_state = self.get_pipeline_last_run_state()
+        return last_state == "success" if last_state is not None else None
+
 
 class SourceTableFieldDefinition(models.Model):
     field = models.CharField(

diff --git a/dataworkspace/dataworkspace/apps/datasets/views.py b/dataworkspace/dataworkspace/apps/datasets/views.py
@@ -453,8 +453,7 @@ def _get_context_data_for_master_dataset(self, ctx, **kwargs):
                     include_types=True,
                 ),
                 tools_links=get_tools_links_for_user(self.request.user, self.request.scheme),
-                pipeline_last_run_succeeded=source_table.get_pipeline_last_run_state()
-                == "success",
+                pipeline_last_run_succeeded=source_table.pipeline_last_run_success(),
             )
             for source_table in sorted(source_tables, key=lambda x: x.name)
         ]