Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add D&B Duns number in the business details page #7443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marijnkampf
Copy link
Contributor

@marijnkampf marijnkampf commented Dec 30, 2024

Description of change

Add D&B Duns number to Companies details page.

Also refactored the file to use constant for 'Not set' text.

Test instructions

When viewing an company's details (Company > Business details) the DUNS number should be shown above Annual turnover. If not available 'Not set' should be displayed.

Screenshots

Before

With DUNS number

image

Without DUNS number
image

After

With DUNS number

image

Without DUNS number set

image

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Dec 30, 2024

data-hub-frontend    Run #58407

Run Properties:  status check passed Passed #58407  •  git commit a93d449c5e: Add D&B Duns number in the business details page
Project data-hub-frontend
Branch Review feature/CLS2-1162-add-duns-number-to-business-details
Run status status check passed Passed #58407
Run duration 01m 38s
Commit git commit a93d449c5e: Add D&B Duns number in the business details page
Committer Marijn Kampf
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (4bc6547) to head (a93d449).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7443   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files        1159     1159           
  Lines       18025    18026    +1     
  Branches     5128     5129    +1     
=======================================
+ Hits        15968    15969    +1     
  Misses       2057     2057           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marijnkampf marijnkampf marked this pull request as ready for review December 30, 2024 11:28
@marijnkampf marijnkampf requested a review from a team as a code owner December 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants