Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/CLS2-1039 Test that email is displayed correctly on EYB lead details page #7436

Merged

Conversation

swenban
Copy link
Contributor

@swenban swenban commented Dec 23, 2024

Description of change

This PR adds a row to the table on the EYB lead details page to display the contact email address for the lead.
If no email is present, the text Not set will be displayed

Document what the PR does and why the change is needed

Test instructions

  1. Visit the details page for an EYB lead that has an email address
    Check that the email address is displayed in the Email row
Screenshot 2024-12-23 at 16 04 22
  1. Visit the details page for an EYB lead with no email address
    Check that the text 'Not set' is displayed in the Email row
Screenshot 2024-12-23 at 16 04 53

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Dec 23, 2024

data-hub-frontend    Run #58344

Run Properties:  status check passed Passed #58344  •  git commit 6ffd4e08d6: Test that email is displayed correctly on eyb lead details page
Project data-hub-frontend
Branch Review feature/CLS2-1039-display-email-on-eyb-lead-details-page
Run status status check passed Passed #58344
Run duration 01m 38s
Commit git commit 6ffd4e08d6: Test that email is displayed correctly on eyb lead details page
Committer Sophie Wenban
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.60%. Comparing base (3170151) to head (6ffd4e0).
Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7436   +/-   ##
=======================================
  Coverage   88.60%   88.60%           
=======================================
  Files        1159     1159           
  Lines       18025    18026    +1     
  Branches     5128     5129    +1     
=======================================
+ Hits        15971    15972    +1     
  Misses       2054     2054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swenban swenban marked this pull request as ready for review December 23, 2024 16:37
@swenban swenban requested a review from a team as a code owner December 23, 2024 16:37
@marijnkampf marijnkampf merged commit 45f8b64 into main Jan 6, 2025
16 checks passed
@marijnkampf marijnkampf deleted the feature/CLS2-1039-display-email-on-eyb-lead-details-page branch January 6, 2025 13:53
chopkinsmade pushed a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants