Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feature/change-contact-consent-to-read-only" #7434

Merged

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Dec 23, 2024

Reverts #7392

Revert the front end back to display the consent value from the legal basis API. The API changes to remove the legal basis API has not been merged yet so no API changes are required to roll this back

Copy link

cypress bot commented Dec 23, 2024

data-hub-frontend    Run #58326

Run Properties:  status check passed Passed #58326  •  git commit 1dc228eb4b: Revert "feature/change-contact-consent-to-read-only (#7392)"
Project data-hub-frontend
Branch Review revert-7392-feature/change-contact-consent-to-read-only
Run status status check passed Passed #58326
Run duration 01m 38s
Commit git commit 1dc228eb4b: Revert "feature/change-contact-consent-to-read-only (#7392)"
Committer Chris Hopkins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.59%. Comparing base (c295b78) to head (1dc228e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/apps/contacts/services/form.js 50.00% 1 Missing ⚠️
src/client/components/ContactForm/index.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7434      +/-   ##
==========================================
- Coverage   88.61%   88.59%   -0.02%     
==========================================
  Files        1161     1159       -2     
  Lines       18027    18025       -2     
  Branches     5127     5128       +1     
==========================================
- Hits        15974    15970       -4     
- Misses       2053     2055       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade marked this pull request as ready for review December 23, 2024 11:15
@chopkinsmade chopkinsmade requested a review from a team as a code owner December 23, 2024 11:15
@chopkinsmade chopkinsmade merged commit 3170151 into main Dec 23, 2024
15 of 16 checks passed
@chopkinsmade chopkinsmade deleted the revert-7392-feature/change-contact-consent-to-read-only branch December 23, 2024 12:41
chopkinsmade pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants