feature/remove-legal-basis-api-connection

[chopkinsmade]

Description of change

As the legal basis API is being decommissioned, the datahub functions that use that service need to be updated to remove that connection. Any time a contact is created or modified, a job is added to the RQ scheduler to update that contacts consent choice in the legal basis API. There are also separate serializers that when used by an endpoint would make a call to the legal basis API to obtain the most recent consent value.

For reference, inside datahub the legal basis API is called the consent service

Checklist

• Has this branch been rebased on top of the current main branch?

  Explanation

  The branch should not be stale or have conflicts at the time reviews are requested.

• Is the CircleCI build passing?

General points

Other things to check

• Make sure fixtures/test_data.yaml is maintained when updating models
• Consider the admin site when making changes to models
• Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
• Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (0207e9e) to head (2c0064f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5857      +/-   ##
==========================================
- Coverage   96.64%   96.60%   -0.04%     
==========================================
  Files        1058     1057       -1     
  Lines       25178    25041     -137     
  Branches     1670     1662       -8     
==========================================
- Hits        24333    24192     -141     
- Misses        689      692       +3     
- Partials      156      157       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DeanElliott96]

LGTM! Would you be able to remove the environment variables from the README as well?

Also just a reminder to remove in the data-hub-deploy repo if you haven't planned on already

[chopkinsmade]

LGTM! Would you be able to remove the environment variables from the README as well?

Also just a reminder to remove in the data-hub-deploy repo if you haven't planned on already

Deploy repo PR raised here https://github.com/uktrade/data-hub-deploy/pull/75

[chopkinsmade]

Hold merging until front end is released