-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add selective testing #764
Conversation
Co-authored-by: Jonathan Shimwell <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #764 +/- ##
========================================
Coverage 95.38% 95.38%
========================================
Files 72 72
Lines 4724 4724
========================================
Hits 4506 4506
Misses 218 218 Continue to review full report at Codecov.
|
GitHub Actions only support one workflow per yml file. Two yml files are required to have separate workflows for PRs to main and develop. |
This is also ready for review @shimwell . What do you think of this? |
Looks like a clever solution, congrats on that you found a nice approach. I see this can also do include neutronics=False at some point as well which could be handy |
Looks great, feel free to merge if ready |
Yes, that would be great to add. I've tried to outline the current problem with doing this in #777, but this can be looked into next |
Proposed changes
PR which adds matrix testing to GitHub Actions to allow testing with different versions of CadQuery, depending on the branch merging.
Pull Requests to Develop - Test just using CQ2.1
Pull Requests to Main - Test using both CQ2.1 and CQ master
Also adds 'if' statement to run_tests.sh script which uses the include-neutronics true/false value to specify which tests should run in each case. This works as intended, however, true/false has not be included in the matrix testing as some non-neutronics scrips still have neutronics dependencies, causing some non-neutronics tests to fail when using the dockerfile built without the neutronics dependencies. This will be addressed in a future PR.
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...