Skip to content

Create fusion reaction file#3599

Merged
timothy-nunn merged 3 commits intomainfrom
create_fusion_reaction_file
Mar 26, 2025
Merged

Create fusion reaction file#3599
timothy-nunn merged 3 commits intomainfrom
create_fusion_reaction_file

Conversation

@chris-ashe
Copy link
Collaborator

@chris-ashe chris-ashe commented Mar 20, 2025

This pull request includes changes to the process/physics.py file and its corresponding unit tests to refactor the import and usage of fusion reaction functions. The most important changes involve moving fusion reaction functions from process.physics_functions to a new module process.fusion_reactions.

Refactor fusion reaction functions:

  • process/physics.py: Changed import from process.physics_functions to process.fusion_reactions and updated function calls accordingly.

Unit test updates:

  • tests/unit/test_fusion_reactions.py: Renamed from tests/unit/test_physics_functions.py and updated imports and function calls to use process.fusion_reactions instead of process.physics_functions.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe self-assigned this Mar 20, 2025
@chris-ashe chris-ashe added the Physics Relating to the physics models label Mar 20, 2025
@chris-ashe chris-ashe force-pushed the create_fusion_reaction_file branch from 5eae679 to cc6effb Compare March 20, 2025 15:59
@chris-ashe chris-ashe requested a review from timothy-nunn March 20, 2025 16:00
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 59.09091% with 90 lines in your changes missing coverage. Please review.

Project coverage is 31.74%. Comparing base (cf82f05) to head (d9c259c).
Report is 136 commits behind head on main.

Files with missing lines Patch % Lines
process/fusion_reactions.py 59.06% 88 Missing ⚠️
process/physics.py 50.00% 1 Missing ⚠️
process/stellarator.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3599      +/-   ##
==========================================
+ Coverage   31.71%   31.74%   +0.02%     
==========================================
  Files          84       85       +1     
  Lines       20152    20160       +8     
==========================================
+ Hits         6392     6400       +8     
  Misses      13760    13760              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe force-pushed the create_fusion_reaction_file branch from 1163c9b to d9c259c Compare March 21, 2025 16:13
Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes to output just organises the code into more sensibly named files

@timothy-nunn timothy-nunn merged commit cb982be into main Mar 26, 2025
18 checks passed
@timothy-nunn timothy-nunn deleted the create_fusion_reaction_file branch March 26, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Physics Relating to the physics models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants