Merged
Conversation
5eae679 to
cc6effb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3599 +/- ##
==========================================
+ Coverage 31.71% 31.74% +0.02%
==========================================
Files 84 85 +1
Lines 20152 20160 +8
==========================================
+ Hits 6392 6400 +8
Misses 13760 13760 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1163c9b to
d9c259c
Compare
timothy-nunn
approved these changes
Mar 26, 2025
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
No changes to output just organises the code into more sensibly named files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
process/physics.pyfile and its corresponding unit tests to refactor the import and usage of fusion reaction functions. The most important changes involve moving fusion reaction functions fromprocess.physics_functionsto a new moduleprocess.fusion_reactions.Refactor fusion reaction functions:
process/physics.py: Changed import fromprocess.physics_functionstoprocess.fusion_reactionsand updated function calls accordingly.Unit test updates:
tests/unit/test_fusion_reactions.py: Renamed fromtests/unit/test_physics_functions.pyand updated imports and function calls to useprocess.fusion_reactionsinstead ofprocess.physics_functions.Checklist
I confirm that I have completed the following checks: