❄️ Refactor cryostat geometry calculations into a new Cryostat class #3594
Merged
timothy-nunn merged 3 commits intomainfrom Mar 21, 2025
Merged
❄️ Refactor cryostat geometry calculations into a new Cryostat class #3594timothy-nunn merged 3 commits intomainfrom
timothy-nunn merged 3 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3594 +/- ##
==========================================
+ Coverage 31.71% 31.74% +0.02%
==========================================
Files 84 85 +1
Lines 20152 20161 +9
==========================================
+ Hits 6392 6400 +8
- Misses 13760 13761 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
approved these changes
Mar 20, 2025
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Much nicer structure, does not change any output, rename any variables, or cause any test issues
ee267b1 to
6f3bd54
Compare
969a11b to
b78bf24
Compare
timothy-nunn
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the cryostat geometry calculations by moving them into a new dedicated
Cryostatclass. The changes also include code cleanup and removal of redundant methods. Here are the most important changes:Refactoring and code organization:
Cryostatclass inprocess/cryostat.py.process/main.pyto initialize the newCryostatclass.process/caller.pyto call therunmethod of the newCryostatclass.Code cleanup:
external_cryo_geometrymethod fromprocess/blanket_library.pyand related calls. [1] [2]cryostat_outputmethod and related calls fromprocess/build.py. [1] [2]These changes improve the modularity and readability of the code by encapsulating cryostat-related functionality within its own class.
Checklist
I confirm that I have completed the following checks: