Add Land IAU parameters to default_vars / control_c48_lnd_iau modifications // #2585 Update for WW3 initialization #2587

dpsarmie · 2025-02-01T02:21:25Z

Commit Queue Requirements:

Fill out all sections of this template.
All sub component pull requests have been reviewed by their code managers.
Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
Commit 'test_changes.list' from previous step

Description:

This PR will add the Land IAU default values to default_vars.sh. The control_c48_lnd_iau test was using a separate version of the global namelist. The test will be changed to use the global_control.nml.IN namelist. The regression test will not have its baselines changed with these modifications.

This PR also combined the following from #2585:
When using PIO restarts, we needed to add a capability to read binary restarts when using runtype=intial. For example, this is used in the high resolution (HR) experiments.

Commit Message:

* UFSWM - Add Land IAU variables to default_vars and allow control_c48_lnd_iau to run using the global_control.nml.IN template.
   * WW3 -  Updated hash for WW3 initialization  (#2585)

Priority:

Normal

Git Tracking

UFSWM:

Closes Add Land IAU values to default_vars #2586
Closes Update for WW3 initialization #2585
Closes Git ignore list missing some build products #2534

Sub component Pull Requests:

Add reading of binary restart with PIO for runtype=initial NOAA-EMC/WW3#1359

UFSWM Blocking Dependencies:

None

Changes

Regression Test Changes (Please commit test_changes.list):

No Baseline Changes.

Input data Changes:

None.

Library Changes/Upgrades:

No Updates

Testing Log:

This allows the control_c48_lnd_iau test to be run off of the global_control.nml.IN namelist and adds the Land IAU defaults to default_vars.sh Even though PERT_CLDS was set in the original test config, the namlist did not have this so the option was not turned on. The test settings reflect the original version of the test and no baseline changes have been made.

dpsarmie · 2025-02-03T20:25:16Z

WW3 changes from 2585 have been added and PR description was modified.

on-behalf-of @ufs-community <[email protected]>

DeniseWorthen · 2025-02-05T00:07:10Z

Why is the Hercules log so odd? It's the "old style" log file, with the list of files from each test appearing w/ an 'OK' etc.

on-behalf-of @ufs-community <[email protected]>

DeniseWorthen · 2025-02-05T13:49:48Z

Why is the Hercules log so odd? It's the "old style" log file, with the list of files from each test appearing w/ an 'OK' etc.

@jkbk2004

DeniseWorthen · 2025-02-05T14:08:24Z

@jkbk2004 Explanation?

jkbk2004 · 2025-02-05T14:09:57Z

@jkbk2004 Explanation?

pushed wrong hercules log and fixed with correct one

DeniseWorthen · 2025-02-05T14:10:56Z

But how did you generate a log like that? As far as I know, rt.sh will no longer generate a log like that.

jkbk2004 · 2025-02-05T14:12:32Z

But how did you generate a log like that? As far as I know, rt.sh will no longer generate a log like that.

rocoto and eclfow are not fully functional on hercules. a few jobs continue to be dropped and rt.sh jusy hangs. @RatkoVasic-NOAA please, re-install rocoto on hercules.

jkbk2004 · 2025-02-05T14:13:20Z

But how did you generate a log like that? As far as I know, rt.sh will no longer generate a log like that.

rocoto and eclfow are not fully functional on hercules. a few jobs continue to be dropped and rt.sh just hangs. and manually recovered log on hercules. but all the rt.conf jobs finished ok. @RatkoVasic-NOAA please, re-install rocoto on hercules.

jkbk2004 · 2025-02-05T14:15:11Z

All tests are done We can start merging process.

DeniseWorthen · 2025-02-05T14:16:12Z

What does running ecflow or rocoto have to do w/ generating a log in the older style?

jkbk2004 · 2025-02-05T14:17:57Z

What does running ecflow or rocoto have to do w/ generating a log in the old

jkbk2004 · 2025-02-05T14:20:13Z

What does running ecflow or rocoto have to do w/ generating a log in the older style?

if ecflow/rocoto doesn't exit successfully, rt.sh hangs and no log is produced.

DeniseWorthen · 2025-02-05T14:24:54Z

a) An issue should be created if that is the case. b) it should be noted that you manually created the log.

JessicaMeixner-NOAA · 2025-02-05T14:29:16Z

WW3 has been merged: NOAA-EMC/WW3@8e67627

jkbk2004 · 2025-02-05T14:31:58Z

It looks ecflow runs ok on hercules: #2454. We will double check in next pr.

jkbk2004 · 2025-02-05T14:54:56Z

@dpsarmie can you update ww3 hash and revert changes in gitmodules ?

dpsarmie · 2025-02-05T16:06:47Z

@dpsarmie can you update ww3 hash and revert changes in gitmodules ?

Done, let me know if you need anything else.

tests/logs/RegressionTests_hercules.log

RatkoVasic-NOAA · 2025-02-05T17:03:37Z

But how did you generate a log like that? As far as I know, rt.sh will no longer generate a log like that.

rocoto and eclfow are not fully functional on hercules. a few jobs continue to be dropped and rt.sh just hangs. and manually recovered log on hercules. but all the rt.conf jobs finished ok. @RatkoVasic-NOAA please, re-install rocoto on hercules.

@jkbk2004 rocoto on Orion and Hercules are maintained by Chris Harrop:

hercules: /apps/contrib/rocoto> ll
total 0
drwxr-x--- 10 charrop noaa-hpc 268 May 11  2023 1.3.5
drwxr-x--- 10 charrop noaa-hpc 268 Feb  1  2024 1.3.6
drwxr-x--- 10 charrop noaa-hpc 268 Jun  3  2024 1.3.7
lrwxrwxrwx  1 charrop noaa-hpc   5 Jun 21  2024 default -> 1.3.7

dpsarmie added 2 commits January 31, 2025 20:03

Remove lnd_iau namelist

50f208e

dpsarmie added the No Baseline Change No Baseline Change label Feb 1, 2025

dpsarmie and others added 2 commits February 3, 2025 14:29

Merge branch 'ufs-community:develop' into fix/merge_global-lnd-iau-nml

06b5e37

Bring in PR#2585 changes

c553242

dpsarmie changed the title ~~Add Land IAU parameters to default_vars / control_c48_lnd_iau modifications~~ Add Land IAU parameters to default_vars / control_c48_lnd_iau modifications // #2585 Update for WW3 initialization Feb 3, 2025

dpsarmie mentioned this pull request Feb 3, 2025

Update for WW3 initialization #2585

Closed

15 tasks

jkbk2004 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Feb 3, 2025

jkbk2004 added 2 commits February 3, 2025 20:30

add orion RT log: passed

6e92d66

add derecho RT log: passed

cf8d8f0

jkbk2004 added the jenkins-ort run ORT testing label Feb 4, 2025

jkbk2004 and others added 7 commits February 4, 2025 15:30

add jet RT log: passed

d088098

add hercules RT log: passed

cd35630

Acorn RT Log: Passed

3849e7a

add git ignore missing list: issue 2534

43af872

ORT Jobs Completed.

0600d15

on-behalf-of @ufs-community <[email protected]>

add gaeac5 RT log passed

3cea4e9

add gaeac6 RT log passed

387d379

add hera RT log: passed

bfb7995

jkbk2004 removed the jenkins-ort run ORT testing label Feb 5, 2025

epic-cicd-jenkins and others added 2 commits February 5, 2025 02:43

ORT Jobs Completed.

e3d6daf

on-behalf-of @ufs-community <[email protected]>

WCOSS2 RT Log: Passed

87d6685

update hercules RT log

6e3b127

jkbk2004 closed this Feb 5, 2025

jkbk2004 reopened this Feb 5, 2025

jkbk2004 mentioned this pull request Feb 5, 2025

Add reading of binary restart with PIO for runtype=initial NOAA-EMC/WW3#1359

Merged

4 tasks

Add final pathing to WW3 submodule repo

cdfb919

jkbk2004 approved these changes Feb 5, 2025

View reviewed changes

jkbk2004 requested review from BrianCurtis-NOAA, FernandoAndrade-NOAA and NickSzapiro-NOAA February 5, 2025 16:16

NickSzapiro-NOAA reviewed Feb 5, 2025

View reviewed changes

tests/logs/RegressionTests_hercules.log Show resolved Hide resolved

NickSzapiro-NOAA approved these changes Feb 5, 2025

View reviewed changes

FernandoAndrade-NOAA approved these changes Feb 5, 2025

View reviewed changes

jkbk2004 merged commit ee3d52d into ufs-community:develop Feb 5, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Land IAU parameters to default_vars / control_c48_lnd_iau modifications // #2585 Update for WW3 initialization #2587

Add Land IAU parameters to default_vars / control_c48_lnd_iau modifications // #2585 Update for WW3 initialization #2587

dpsarmie commented Feb 1, 2025 •

edited by jkbk2004

Loading

dpsarmie commented Feb 3, 2025 •

edited

Loading

DeniseWorthen commented Feb 5, 2025

DeniseWorthen commented Feb 5, 2025

DeniseWorthen commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

DeniseWorthen commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025 •

edited

Loading

jkbk2004 commented Feb 5, 2025

DeniseWorthen commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

DeniseWorthen commented Feb 5, 2025

JessicaMeixner-NOAA commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

dpsarmie commented Feb 5, 2025

RatkoVasic-NOAA commented Feb 5, 2025 •

edited

Loading

Add Land IAU parameters to default_vars / control_c48_lnd_iau modifications // #2585 Update for WW3 initialization #2587

Add Land IAU parameters to default_vars / control_c48_lnd_iau modifications // #2585 Update for WW3 initialization #2587

Conversation

dpsarmie commented Feb 1, 2025 • edited by jkbk2004 Loading

Commit Queue Requirements:

Description:

Commit Message:

Priority:

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

Library Changes/Upgrades:

Testing Log:

dpsarmie commented Feb 3, 2025 • edited Loading

DeniseWorthen commented Feb 5, 2025

DeniseWorthen commented Feb 5, 2025

DeniseWorthen commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

DeniseWorthen commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025 • edited Loading

jkbk2004 commented Feb 5, 2025

DeniseWorthen commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

DeniseWorthen commented Feb 5, 2025

JessicaMeixner-NOAA commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

jkbk2004 commented Feb 5, 2025

dpsarmie commented Feb 5, 2025

RatkoVasic-NOAA commented Feb 5, 2025 • edited Loading

dpsarmie commented Feb 1, 2025 •

edited by jkbk2004

Loading

dpsarmie commented Feb 3, 2025 •

edited

Loading

jkbk2004 commented Feb 5, 2025 •

edited

Loading

RatkoVasic-NOAA commented Feb 5, 2025 •

edited

Loading