Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart row invalidation when performing inline edit #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MartinMystikJonas
Copy link
Contributor

Only affected rows are redrawed

@MartinMystikJonas
Copy link
Contributor Author

I just noticed that for some reason edited line is not highlighted with .success class. I will look at it.

@MartinMystikJonas
Copy link
Contributor Author

Damn, containing tr is not part of snippet. Therefore no changes to tr is possible. And HTML does not allow any other element to wrap each row or wrap entire body (in case tbody would be used as snippet wrapper for each row).

Any idea how to manage to make this working?

@MartinMystikJonas
Copy link
Contributor Author

Fixed in second commit - using JS to mark edited row

@MartinMystikJonas
Copy link
Contributor Author

Noticed some more errors. I will look at it.

@MartinMystikJonas MartinMystikJonas changed the title Smart row invalidation when performing inline edit Smart row invalidation when performing inline edit [WIP] Apr 29, 2015
@MartinMystikJonas
Copy link
Contributor Author

@MartinMystikJonas MartinMystikJonas changed the title Smart row invalidation when performing inline edit [WIP] Smart row invalidation when performing inline edit Apr 30, 2015
@uestla
Copy link
Owner

uestla commented May 9, 2015

Could you please squash it into one commit for better clarity of all changes? Thanks.

@MartinMystikJonas
Copy link
Contributor Author

Squashed

@uestla
Copy link
Owner

uestla commented Mar 3, 2016

Can I ask you for update your changes to use the same coding standards as the rest of the library?

It really helps the readability...

Thank you.

@uestla uestla force-pushed the master branch 2 times, most recently from d263406 to fec6a04 Compare June 25, 2016 13:53
@uestla uestla force-pushed the master branch 2 times, most recently from 376c45f to 56c9be8 Compare July 8, 2016 00:53
@uestla
Copy link
Owner

uestla commented Jul 9, 2016

I like this idea very much, but there are some coding non-standards in your code.

Maybe I'll use this idea but implement it in another way with mentioning this PR.
Thank you anyway.

@uestla
Copy link
Owner

uestla commented Jul 10, 2016

The only thing that this brings is to transfer less data through AJAX, am I right? Database queries would be triggered at the same amount...

@uestla uestla force-pushed the master branch 5 times, most recently from c4333ec to 003cc91 Compare April 3, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants