Code updated to run on SDK 33 and Gradle 7.5 #12

graffiti75 · 2023-04-14T21:26:54Z

Unfortunately this repo is not working anymore because the last time it was updated was 3 years ago.

This repo is used on course "Android Kotlin Developer" of Udacity, more specifically on chapter "Advanced Android Apps with Kotlin - Part 2", class "5.7. Project: Build a Location Reminder App".
As a Code Reviewer for the Android course in Udacity, in order to help students of this course, I decided to create this PR to update the repo.
Between the requested changes, we have:
- SDK version updated to version 33.
- Gradle version updated to 7.5.
- Dependencies updated on app/build.gradle.
- AndroidManifest.xml updated.
- settings.gradle updated.
- Indentations fixed.

- Location tracking implemented

- Back Pressed callback added to Fragments - Old Menu implementations updated to menuHost.addMenuProvider

- Updating Permission's checking. - Location tracking fixed. - registerForActivityResult added. - onActivityResult and onRequestPermissionsResult removed. - Permission's Extension methods created.

…ionFragment

islamalsawy · 2023-05-02T16:21:30Z

...ity/project4/locationreminders/savereminder/selectreminderlocation/SelectLocationFragment.kt

+     * When the user confirms on the selected location, send back the selected location details
+     * to the view model and navigate back to the previous fragment to save the reminder and add
+     * the geofence.
+     */


@graffiti75 I can see you've shifted the TODO comments a little bit, so could you replicate the same syntax again? As I can see "TODO" word is missing and please use // to represent single lines of comments.

Hello @islamalsawy .

Let me explain to you what happened here.

This PR was created 3 weeks ago with the intention to fix the starter code of project Build a Location Reminder App.

3 weeks ago the only commit to be merged with udacity:master was this commit, that is the starter commit for students to work on:

Code updated to run on SDK 33 and Gradle 7.5

Since then I kept implementating this project because I needed to check how deprecated Udacity's suggestions were on Advanced Android with Kotlin course. There are several deprecations here. All the following concepts are deprecated, and Udacity haven't updated this in the course:

Notifications, that now need Runtime Permissions and need newer Flags to be able to run.

Geofences, that were incorrectly using JobIntentService (that doesn't work anymore since 2021), and now need to be implemented using WorkManager.

onRequestPermission method, that was deprecated by Google, and now need to be replaced by registerForActivityResult.

onCreateOptionsMenu and onOptionsItemSelected methods, that are now deprecated by Google, and need to be replaced by MenuHost.addMenuProvider.

onActivityResult method, that is now deprecated by Google, and need to be replaced by registerForActivityResult.

Also, the Location Tracking feature using GPS in Android that was never taught in this Udacity course. This feature is requested on project Build a Location Reminder App, and in the last years the implementation of this feature in Android changed dramatically.

Any student enrolled on this course, to have this final project finished, will need to fix all those deprecations! I think this is a very heavy load for them to carry, right?

We have a lot to fix on this course!!

Anyway, to begin with, what I suggest here is that I close this PR and create a newer one with only the starter commit (as explained earlier). This way future students will be able, at least, to start this project with an updated starter code, containing all the correct Gradle dependencies and SDK versions up to date.

If you need further explanations, please contact me in private on Udacity Circle website.

New PR created: #14

@graffiti75 Thank you for putting things in context. Let's start with approving this new PR. I am going to share more details with you Circle.

islamalsawy · 2023-05-03T08:32:18Z

starter/app/src/main/java/com/udacity/project4/authentication/AuthenticationActivity.kt

+        binding = DataBindingUtil.setContentView(this, layoutId)
+        binding.authButton.text = getString(R.string.login)
+
+        // TODO: Line below was commented to avoid losing time Login In on Firebase


@graffiti75 I can see you've added new lines, but I can not see any TODOs listed here in this file for the learners!

New PR created: #14

islamalsawy · 2023-05-03T08:38:45Z

...p/src/main/java/com/udacity/project4/locationreminders/geofence/GeofenceBroadcastReceiver.kt


-//TODO: implement the onReceive method to receive the geofencing events at the background
+	override fun onReceive(context: Context, intent: Intent) {


@graffiti75 Kindly, where I can find the TODO: implement onRecieve method... in your updated code?

New PR created: #14

islamalsawy · 2023-05-03T08:40:59Z

...p/src/main/java/com/udacity/project4/locationreminders/reminderslist/ReminderListFragment.kt

-    override fun onOptionsItemSelected(item: MenuItem): Boolean {
-        when (item.itemId) {
-            R.id.logout -> {
-//                TODO: add the logout implementation


@graffiti75 Where I can find tis TODO in your updated code?

New PR created: #14

islamalsawy · 2023-05-03T08:44:43Z

...pp/src/main/java/com/udacity/project4/locationreminders/savereminder/SaveReminderFragment.kt

        }

+        // Use the user entered reminder details to:


@graffiti75 I can see this a TODO, so could you add the word TODO?

New PR created: #14

islamalsawy · 2023-05-03T08:54:14Z

starter/app/src/main/res/layout/fragment_select_location.xml

        android:layout_width="match_parent"
        android:layout_height="match_parent">
-        <!--TODO: Add the map fragment for the user to select the location-->


@graffiti75 Kindly, why did you decide to delete this TODO?

New PR created: #14

islamalsawy · 2023-05-03T08:56:09Z

starter/app/src/main/res/values/strings.xml

@@ -1,5 +1,5 @@
 <resources>
-    <string name="app_name">Location Reminders</string>
+    <string name="app_name">AAA Location Reminders</string>


@graffiti75 Could explain why did you add AAA, please?

New PR created: #14

islamalsawy · 2023-05-03T09:56:11Z

starter/app/build.gradle

-    // Architecture Components
-    //Navigation dependencies
-    implementation 'androidx.appcompat:appcompat:1.2.0'
-    implementation 'androidx.constraintlayout:constraintlayout:2.0.0-rc1'


@graffiti75 Do you see the first change of this PR is not required here ?

New PR created: #14

SudKul · 2023-05-04T08:47:33Z

@islamalsawy
Let me know when the PR is ready to merge. Also, can you set up some time with the Mentor to update all projects in the ND with the same Gradle, SDK, and dependencies? This will be a paid assignment. Check with Varun/Xiaodi for more details.

islamalsawy · 2023-05-04T13:38:25Z

@SudKul Sure. I am going to review the PR and let you know once finished by EOD tomorrow. Thank you for letting me know. Also, I am going to check with the team for the next collaborations of the ND.

- JobIntentService replaced by WorkManager on GeoFence implementation

- FakeDataSource code added

- App name changed to the originall

- setMapClick, fetchGeocode, putMarkerOnMap, putCircleOnMap and removeMarkers

- On SaveReminderFragment, changed setExpirationDuration to NEVER_EXPIRE - On SaveReminderFragment, removed geofencingClient.removeGeofences

- locationPermissionRequest added - geocoder.getFromLocation now implemented for cases below Build.VERSION_CODES.TIRAMISU

Code updated to run on SDK 33 and Gradle 7.5

99b1b59

graffiti75 requested a review from a team as a code owner April 14, 2023 21:26

graffiti75 requested review from SudKul and removed request for a team April 14, 2023 21:26

graffiti75 added 11 commits April 15, 2023 21:14

Authentication flow implemented

d8ffa9d

Updating Gradle for Koin Tests

c37e032

Authentication flow transferred to AuthenticationActivity

70c3ce4

MapsActivity added to the project

9d4e191

Maps implementation transferred to SelectLocationFragment

35ec2f6

- Location tracking implemented

Navigation bugs fixed

2457bc3

- Back Pressed callback added to Fragments - Old Menu implementations updated to menuHost.addMenuProvider

SelectLocationFragment refactored.

78d4976

- Updating Permission's checking. - Location tracking fixed. - registerForActivityResult added. - onActivityResult and onRequestPermissionsResult removed. - Permission's Extension methods created.

Removed unused methods on SelectLocationFragment

c76efc3

Method onLocationSelected() added to setPoiClick() inside SelectLocat…

91f6ab0

…ionFragment

Geofences added and Notification implemented

b088df2

Save button added on SelectLocationFragment

81ca5d2

islamalsawy reviewed May 2, 2023

View reviewed changes

islamalsawy reviewed May 3, 2023

View reviewed changes

graffiti75 added 5 commits May 23, 2023 17:21

Design added to ReminderDescriptionActivity

1dee279

- JobIntentService replaced by WorkManager on GeoFence implementation

Comments from latest commit removed

cbfad3b

RemindersListViewModel tests added

3ad4883

- FakeDataSource code added

SaveReminderViewModelTest tests added

3e1436d

RemindersActivityTest tests added

d749465

graffiti75 added 19 commits May 26, 2023 13:32

ReminderListFragmentTest tests added

5b1c93a

RemindersLocalRepositoryTest tests added

694ccd1

RemindersDaoTest tests added

92c5c10

Login re-enabled

13af776

- App name changed to the originall

Method checkIfUserIsLogged implemented on AuthenticationActivity

2982664

Map methods added to SelectLocationFragment

c8f4045

- setMapClick, fetchGeocode, putMarkerOnMap, putCircleOnMap and removeMarkers

Comments from latest commit removed

644840e

wrapEspressoIdlingResource added to RemindersLocalRepository

1f25352

Fixing code review spec from FakeDataSource.kt, lines 24 and 37

db83eef

- On SaveReminderFragment, changed setExpirationDuration to NEVER_EXPIRE - On SaveReminderFragment, removed geofencingClient.removeGeofences

Declared on FakeDataSource the reminderList data as NotNull

b0d8cf7

Method enableMyLocation implemented on SelectLocationFragment

f322768

- locationPermissionRequest added - geocoder.getFromLocation now implemented for cases below Build.VERSION_CODES.TIRAMISU

Comments from latest commit removed

5176be6

Dispatchers.Main added to method updateCurrentPoi

78e58c4

checkGeoFencePermissions added on SaveReminderFragment

ac3c247

Notifications now working for multiple triggering Geofences

3372bb9

Small fixes on Notification feature

71c0808

Espresso test for Toast message added

77c1c1a

Trying to fix addingReminder_verifyIfToastIsCalled

b22af65

Test addingReminder_verifyIfToastIsCalled fixed

e3e5ddc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code updated to run on SDK 33 and Gradle 7.5 #12

Code updated to run on SDK 33 and Gradle 7.5 #12

graffiti75 commented Apr 14, 2023

islamalsawy May 2, 2023

graffiti75 May 3, 2023 •

edited

Loading

graffiti75 May 3, 2023 •

edited

Loading

islamalsawy May 5, 2023

islamalsawy May 3, 2023

graffiti75 May 3, 2023

islamalsawy May 3, 2023

graffiti75 May 3, 2023

islamalsawy May 3, 2023

graffiti75 May 3, 2023

islamalsawy May 3, 2023

graffiti75 May 3, 2023

islamalsawy May 3, 2023

graffiti75 May 3, 2023

islamalsawy May 3, 2023

graffiti75 May 3, 2023

islamalsawy May 3, 2023

graffiti75 May 3, 2023

SudKul commented May 4, 2023 •

edited

Loading

islamalsawy commented May 4, 2023


		//TODO: implement the onReceive method to receive the geofencing events at the background
		override fun onReceive(context: Context, intent: Intent) {

Code updated to run on SDK 33 and Gradle 7.5 #12

Are you sure you want to change the base?

Code updated to run on SDK 33 and Gradle 7.5 #12

Conversation

graffiti75 commented Apr 14, 2023

Choose a reason for hiding this comment

graffiti75 May 3, 2023 • edited Loading

Choose a reason for hiding this comment

graffiti75 May 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SudKul commented May 4, 2023 • edited Loading

islamalsawy commented May 4, 2023

graffiti75 May 3, 2023 •

edited

Loading

graffiti75 May 3, 2023 •

edited

Loading

SudKul commented May 4, 2023 •

edited

Loading