Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/#1767 ga import #1792

Closed
wants to merge 2 commits into from
Closed

Bug/#1767 ga import #1792

wants to merge 2 commits into from

Conversation

jamesvanmil
Copy link
Contributor

Fixes #1767

Adds an additional condition before running the tally_results method, to handle the case where additional retries don't succeed (in this case the rescue_and_retry returns True)

The existing spec for this class didn't provide a useful starting point for testing the changes I made - let me know if you think we should bring it in.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.8%) to 90.773% when pulling 524dc09 on bug/#1767-ga-import into 1f8cba6 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.8%) to 90.773% when pulling bfaa4c6 on bug/#1767-ga-import into 2fecf19 on develop.

@hortongn
Copy link
Member

@jamesvanmil Coverage droppped almost 6%. Maybe bring over spec/services/hyrax/user_stat_importer_spec.rb from Hyrax as well?

@jamesvanmil
Copy link
Contributor Author

@hortongn Took a look at that and unfortunately it comes with a few failures - not sure whether it means the code isn't working or the specs aren't working. Will try to make more time later this week to find out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants