Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decodes flash card text strings prior to assignment in the player #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clpetersonucf
Copy link
Member

A simple addition to the player to decode question/answer strings via the innerHTML property trick.

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that this convinces screen readers (at least Voiceover) to read special characters correctly instead of reading their unicode character codes.

The method seems a bit weird to me. There's got to be some magic happening somewhere that's accomplishing the actual conversion, it'd be better to use that rather than to filter text through a fake textarea tag. But this works for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants