Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chess icon #1005

Closed
wants to merge 1 commit into from
Closed

Conversation

eaglersdeveloper
Copy link
Contributor

New icon for GNOME Chess:

chess-app

@eaglersdeveloper
Copy link
Contributor Author

Please, don't merge now

@madsrh
Copy link
Member

madsrh commented Dec 2, 2018

Didn't @ubuntujaggers work on a chess icon?

@ubuntujaggers
Copy link
Contributor

I was working on some designs with a chess piece and just couldn't get it to quite work at all sizes - I think this chessboard is iconic enough to stand for chess without a piece on it, and the greys are from the Suru palette. Also I think this one was accepted upstream :)

@Feichtmeier
Copy link
Member

So, @eaglersdeveloper why can't we merge it, Jaggers is okay and peeps like it?

@eaglersdeveloper
Copy link
Contributor Author

I wanted to experiment with the icon, but if you like it, you can merge.

@Feichtmeier
Copy link
Member

Nono take your time

@Feichtmeier
Copy link
Member

@eaglersdeveloper are you still working on this?

@clobrano clobrano mentioned this pull request Dec 15, 2018
@Feichtmeier
Copy link
Member

@eaglersdeveloper are you still working on this? Or shall we merge it?

@eaglersdeveloper
Copy link
Contributor Author

Users might think that this is Сheckers, not Сhess.

@Feichtmeier
Copy link
Member

What about this one snwh/suru-icon-theme#102 (comment)
By @ubuntujaggers

@ubuntujaggers
Copy link
Contributor

Possibly the chess piece on @eaglersdeveloper 's background? I wasn't very happy with the piece at smaller sizes, but the top three at least look okay on my phone..

@Feichtmeier
Copy link
Member

What if you symbolise one of the chess figures from above instead of from the front?

@clobrano
Copy link
Member

Possibly the chess piece on @eaglersdeveloper 's background? I wasn't very happy with the piece at smaller sizes, but the top three at least look okay on my phone..

what if instead of a full chess piece, we use only a symbol, like a crown. It should scale better at smaller sizes

@clobrano
Copy link
Member

clobrano commented Jan 3, 2019

@eaglersdeveloper, please do not forget this one or we shall close it

@eaglersdeveloper
Copy link
Contributor Author

@eaglersdeveloper
Copy link
Contributor Author

OK, merge it. I have no ideas.

@clobrano
Copy link
Member

clobrano commented Jan 3, 2019

Considering what said, this PR is not ready for merging. Closing it for now, do not delete the branch so you can reopen it if you want

@clobrano clobrano closed this Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants