Skip to content

Add the login-unknown configuration option #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wolneykien wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add the login-unknown configuration option #246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04ed040
Add the 'login-unknown' configuration option
wolneykien Jul 12, 2017
7121f1a
Lookup 'login-unknown' first in the seat configuration, then in the
wolneykien Oct 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/seat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,8 +998,15 @@ create_user_session (Seat *seat, const gchar *username, gboolean autostart)
l_debug (seat, "Creating user session");

/* Load user preferences */
gboolean login_unknown = FALSE;

Copy link
Collaborator

@robert-ancell robert-ancell Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove empty line.

if (seat_get_string_property (seat, "login-unknown"))
Copy link
Collaborator

@robert-ancell robert-ancell Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this into data/lightdm.conf with the default value and some documentation.

login_unknown = seat_get_boolean_property (seat, "login-unknown");
else
login_unknown = config_get_boolean (config_get_instance (), "LightDM", "login-unknown");

g_autoptr(User) user = accounts_get_user_by_name (username);
if (!user)
if (!user && !login_unknown)
{
l_debug (seat, "Can't login unknown user '%s'", username);
return NULL;
Expand Down