Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken scale-monitor-framebuffer #1847

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

befanyt
Copy link
Contributor

@befanyt befanyt commented Oct 28, 2024

This PR tries to fix #1843

Enabled glib-combile-schemas --strict again and strips out incompatible schema values (pre F41) via dirty sed:
, 'xwayland-native-scaling' and accent-color="slate"

Probably there are nicer ways to do this, but it results in strict checked schemas as tested on latest, gts and beta:

❯ rpm-ostree status
State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: no runs since boot
Deployments:
● ostree-unverified-registry:ghcr.io/befanyt/bluefin:gts
                   Digest: sha256:7b19b8a71a101a9e405b4605e0750aff4e2b2d234f3c4a46f722fdcaa3174a30
                  Version: 39.20241027.0 (2024-10-28T20:46:13Z)

❯ gsettings get org.gnome.mutter experimental-features
['scale-monitor-framebuffer']

❯ rpm-ostree status
State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: no runs since boot
Deployments:
● ostree-unverified-registry:ghcr.io/befanyt/bluefin:latest
                   Digest: sha256:52c1eacb99b1b00ac9952ab64b77067629b51aba92ed78e34c40544300bbc0fa
                  Version: 40.20241027.0 (2024-10-28T20:40:52Z)

❯ gsettings get org.gnome.mutter experimental-features
['scale-monitor-framebuffer']

❯ rpm-ostree status
State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: no runs since boot
Deployments:
● ostree-unverified-registry:ghcr.io/befanyt/bluefin:beta
                   Digest: sha256:a5df3522395ac2231e96171d922528c1b64f0b26f14345b0b98060c5f2c546f3
                  Version: 41.20241028.0 (2024-10-28T20:46:52Z)

❯ gsettings get org.gnome.mutter experimental-features
['scale-monitor-framebuffer', 'xwayland-native-scaling']

Instead of current behavior:

❯ rpm-ostree status
State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: no runs since boot
Deployments:
● ostree-image-signed:docker://ghcr.io/ublue-os/bluefin:latest
                   Digest: sha256:a39aa0fe06b2b04ebe2890b963eef9277c7442c7aebf891d761c27c4a42199d2
                  Version: 40.20241027.0 (2024-10-28T21:18:19Z)

❯ gsettings get org.gnome.mutter experimental-features
@as []

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Oct 28, 2024
@castrojo
Copy link
Member

Oh this might be a better solution compared to what I just did, which was match bazzite, which has a working config: #1846

Happy to undo that and go with this if it works though! Let me gather some reviewers.

@befanyt
Copy link
Contributor Author

befanyt commented Oct 28, 2024

Oh you already did a fix! I didn't see that. Well, whatever fixes the issue 👍

@castrojo
Copy link
Member

I haven't tested it yet though, yours for sure works so let's hold onto this, running out of time for release so it might be worth backing mine out and landing this.

I pushed it to latest though.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 28, 2024
@castrojo castrojo added this pull request to the merge queue Oct 28, 2024
@Malix-Labs
Copy link

Need #1846 to be reverted before merging

@Malix-Labs
Copy link

Malix-Labs commented Oct 28, 2024

This PR tries to solve #1843

@befanyt can you change that part to fix #1843 please ?

@Malix-Labs

This comment was marked as spam.

@castrojo
Copy link
Member

I can set the issue states by hand, please use emojis instead of posting small comments, we get an email every time you post!

Merged via the queue into ublue-os:main with commit 699179c Oct 28, 2024
62 of 64 checks passed
karman011 pushed a commit to karman011/bluefin that referenced this pull request Oct 29, 2024
@befanyt befanyt deleted the fix-scaling branch October 31, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken fractional scaling
4 participants