Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Update to latest version of Build-Container-Installer and include building Aurora ISOs #1116

Merged
merged 29 commits into from
Apr 11, 2024
Merged

chore(ci): Update to latest version of Build-Container-Installer and include building Aurora ISOs #1116

merged 29 commits into from
Apr 11, 2024

Conversation

noelmiller
Copy link
Member

@noelmiller noelmiller commented Apr 10, 2024 •
edited
Loading

Summary

This PR includes a number of things in it.

  1. Using the latest pinned version of Build Container Installer
  2. Using a folder upload rather than individual file uploads
  3. Creates split workflows to build ISOs

Blockers

  • Secrets needed for Aurora Buckets
  • Test ISOs that are being built with main
  • Pinned version of Build-Container Installer needs to be released
  • Pin to versioned release
  • Test ISOs built with pinned release version

noelmiller and others added 24 commits April 5, 2024 00:03
@noelmiller
chore(ci): test building ISO with newer version of build-container-in…
8db3700 
…staller
@JasonN3
fix: use path (#1090)
c9429ac
@noelmiller
Merge branch 'main' into testing
4f5045d
@noelmiller
chore(ci): use flatpak upload folder instead
b56259c
@noelmiller
chore(ci): fixed directory name
4428c8d
@noelmiller
chore(ci): try @deps branch
2ff08b9
@noelmiller
chore(ci): remove /github/workspace
29bb73d
@noelmiller
chore(ci): fixed up naming
773cf71
@noelmiller
Merge branch 'main' into testing
64a85a7
@noelmiller
Merge branch 'main' into testing
9f53f95
@noelmiller
chore(ci): added kde_flatpaks in preparation for aurora
a38e0b2
@noelmiller
Merge branch 'main' into testing
9ea7d30
@noelmiller
Merge branch 'main' into testing
3393791
@m2Giles @castrojo
@NiHaiden @noelmiller
chore(ci): build Aurora ISOs using a split workflow. (#1103)
0383801 
Co-authored-by: Jorge O. Castro <[email protected]>
Co-authored-by: Niklas Haiden <[email protected]>
Co-authored-by: Noel Miller <[email protected]>
@noelmiller
chore(ci): move logic out of matrix
873a082
@m2Giles
Aurora_isos_testing (#1112)
8be7521
@noelmiller
chore(ci): add quotes
c88ed1f
@m2Giles
fix: don't build 40
772b946
@m2Giles
fix: don't build 40
8e95bed
@noelmiller
chore(ci): single quotes!
7db1d97
@m2Giles
feat: aurora and bluefin iso build workflows (#1114)
8ac022b
@noelmiller
chore(ci): remove 38
73744b1
@noelmiller
chore(ci): Add R2 secrets logic to upload to different buckets
293d5cf
@noelmiller
Merge branch 'main' into testing
f36a6d6
@m2Giles
Copy link
Member

m2Giles commented Apr 11, 2024

We have our flatpak lists duplicated

@castrojo
Copy link
Member

Yeah and shouldn't we use the silverblue and kinoite instead of kde_flatpaks, gnome_flatpaks, and aurora_flatpaks so we match how we organize the rest of the repo?

@noelmiller
Copy link
Member Author

We have our flatpak lists duplicated

I think those got reintroduced on a merge from my branch. Removed them.

@noelmiller
Copy link
Member Author

noelmiller commented Apr 11, 2024 •
edited
Loading

Yeah and shouldn't we use the silverblue and kinoite instead of kde_flatpaks, gnome_flatpaks, and aurora_flatpaks so we match how we organize the rest of the repo?

I guess I would want a second opinion on this @m2Giles. I personally think it's clearer to have them delineated as bluefin_flatpaks and aurora_flatpaks.

@noelmiller noelmiller self-assigned this Apr 11, 2024
@noelmiller noelmiller marked this pull request as ready for review April 11, 2024 19:05
@noelmiller
Copy link
Member Author

I'm going to say this is ready for review. The main blocker for building aurora ISOs shouldn't affect this going in. We can always fix it if the bucket name for aurora needs to be adjusted.

@m2Giles
Copy link
Member

m2Giles commented Apr 11, 2024

I'm impartial to the names for the flatpak dirs.

One reason to stay with the brand names is that we invoke the workflow with this names. But we already use the kinoite/silverblue names inside as variables.

NiHaiden
NiHaiden reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@NiHaiden NiHaiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks Noel!

m2Giles
m2Giles approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@m2Giles m2Giles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get Aurora Shipping!

@noelmiller noelmiller added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 44d0e40 Apr 11, 2024
163 checks passed
@noelmiller noelmiller deleted the testing branch April 11, 2024 22:08
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
@noelmiller @JasonN3
@m2Giles @castrojo @NiHaiden
chore(ci): Update to latest version of Build-Container-Installer and …
68ac006 
…include building Aurora ISOs (ublue-os#1116)

Co-authored-by: Jason N <[email protected]>
Co-authored-by: m2 <[email protected]>
Co-authored-by: Jorge O. Castro <[email protected]>
Co-authored-by: Niklas Haiden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiHaiden NiHaiden NiHaiden left review comments

@m2Giles m2Giles m2Giles approved these changes

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

@bsherman bsherman Awaiting requested review from bsherman

Assignees

@noelmiller noelmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@noelmiller @m2Giles @castrojo @NiHaiden @JasonN3