Add various project related fields #827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-z
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Thanks for the contribution.
We usually add properties as needed. Is that the case for you? If so, can you add tests to make sure that the added GitLab "attributes" do indeed exist and that JSON serialization/deserialization work as expected (e.g. I noticed that one of the GitLab "attributes" could actually be null and so, with the current code, deserialization would throw)?
| @@ -85,6 +85,9 @@ public class Project | |||
| [JsonPropertyName("repository_access_level")] | |||
| public RepositoryAccessLevel RepositoryAccessLevel { get; set; } | |||
|
|
|||
| [JsonPropertyName("packages_enabled")] | |||
| public bool PackagesEnabled { get; set; } | |||
There was a problem hiding this comment.
I tested this on my side and it can be null. Please make it a nullable bool.
| [JsonPropertyName("infrastructure_access_level")] | ||
| public string InfrastructureAccessLevel { get; set; } | ||
|
|
||
| [JsonPropertyName("model_experiments_access_level")] |
There was a problem hiding this comment.
AFAICT these properties are not part of a project response
model_experiments_access_level
model_registry_access_level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added various missing settings to Project and ProjectUpdate to allow setting the access levels on these features.