Feature: View Claim Button #187
Conversation
|
Currently testing with this... This does not work. 
|
| @@ -134,6 +134,9 @@ table[data-claim-rendered] #controls { | |||
| table[data-claim-rendered] button { | |||
| opacity: 0.5; | |||
| } | |||
| table[data-claim-rendered] button.hide { | |||
| display:none !important; | |||
There was a problem hiding this comment.
!important seems like a bad idea. You should use more specific selectors instead, or put this at the bottom of the css file.
There was a problem hiding this comment.
didn't want to make it more complicated for a simple hide function for this kind of feature,
otherwise we need to double every selector for buttons.
if that's okay I'm going to move the !important to the bottom of the css file.
we are definitely not on the same page on this one. :) I'm guessing it's the same issue with the one in #173 if you are using auto generated permits via that's the same conversation where we left on #173 |
To clarify, this is not currently implemented? Doesn't it make more sense to write the data when we're claiming from this UI? It seems that this dependency on an external system makes it less maintainable than it needs to be. Anyways given that I have less time for code reviews nowadays I'll need to ultimately delegate my review to @rndquu It would be helpful if you can provide me the functional test URL so I can see the UI. |
yes inserting the permit to the db is not implemented. I really think that the permits should be inserted to the db where and when they are generated at first place which is ubiquibot. assume that a permit is generated but the beneficiary doesn't even click the link and open the UI. in that case, the permit wouldn't be listed on audit pages as unclaimed.
let me check about the functional test URL. I have no idea the automated deployments works right now. it might take some time. |
I'm not sure how we can confirm that your implementation works if you haven't tested it.
You just need to provide the query parameter that represents the permit. We can use the latest deploy on this pull and then append the query parameter to test. |
I've tested it locally as the ubiquibot is an external dependency in this case. seems like we were assuming different requirements for this task and the one before.
if it is a test on automated deployments that you want, nothing really works I guess as there is no code inserting the permit to the db. As I said before I was assuming ubiquity bot is already inserting the permits to the database. If that's not the case we first need to decide where we should be putting the db insert logic, to the ubiquibot or to the UI. |
Can you explain how I can test this?
Makes sense for the bot to write to the permits database upon permit generation! |
on my local 1- edit |
|
I gave you edit access to our Supabase why not just insert the test permit and then provide the full url here? I can only do all those steps from computer but most of the time I'm reviewing from mobile. |
Am I supposed to claim it? It has two rewards embedded, bot are claimable according to the UI. |
in order to test whole process I supposed you would want to claim it. I extracted your address from previous link. so if you want to claim you can. if you only want to test ui i also updated the previous link that you said didn't work. that's the supposed version of ui when you claim the permit. rewards are generated via script with the amount 0. by default it creates two permits so i didn't edit it. |
|
Love to see it. 
This didn't happen for me so I don't understand why that would be the case for you. |
Resolves #182