Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use actions/upload-artifact@v4 #120

Merged
merged 1 commit into from
Nov 6, 2024
Merged

ci: use actions/upload-artifact@v4 #120

merged 1 commit into from
Nov 6, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Nov 6, 2024

Artifact actions v3 will be deprecated by December 5, 2024. After this date using v3 of these actions will result in a workflow failure.

This PR upgrades usage of actions/upload-artifact to v4.

Migration guide: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

@rndquu rndquu requested a review from Keyrxng November 6, 2024 15:15
Copy link
Contributor

@Keyrxng Keyrxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think tallyrepo.yml is ever going to be used, it was the workflow for the V1 of the CLI for building a leaderboard with.

#112 refactors the CLI to be run once and it'll fill the DB which was decided to be the way forward with tallying/building an auditable dataset.

Otherwise all good

@rndquu
Copy link
Member Author

rndquu commented Nov 6, 2024

I don't think tallyrepo.yml is ever going to be used, it was the workflow for the V1 of the CLI for building a leaderboard with.

#112 refactors the CLI to be run once and it'll fill the DB which was decided to be the way forward with tallying/building an auditable dataset.

Otherwise all good

I'll merge it for now in order to stop receiving github notifications via email.

@rndquu rndquu merged commit 222e02f into main Nov 6, 2024
@rndquu rndquu deleted the rndquu-patch-2 branch November 6, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants