Ensure Metadata is Properly Passed to LogReturn in Logging Class #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue in the logging class where the metadata parameter was not consistently passed to the LogReturn instance within the _log method.
Keyrxng
reviewed
Oct 28, 2024
src/logs.ts
Outdated
| return new LogReturn( | ||
| { | ||
| raw: logMessage, | ||
| diff: this._diffColorCommentMessage(type, logMessage), | ||
| type, | ||
| level, | ||
| }, | ||
| metadata | ||
| metadata // Ensure metadata is passed correctly here |
There was a problem hiding this comment.
metadata was already passed in here, you've just added a comment
|
@imabutahersiddik Hello bud, this feature should fill the |
This comment was marked as spam.
This comment was marked as spam.
0x4007
reviewed
Oct 28, 2024
There was a problem hiding this comment.
There's nothing about trace in the spec. @gentlementlegen rfc
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue in the logging class where the metadata parameter was not consistently passed to the LogReturn instance within the _log method.
Resolves #46