-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated exports for the logger #23
feat: updated exports for the logger #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are changes needed within the changelogs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first time updating a changelog, things look ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelogs are automated by release-please
so will be re-generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keyrxng please revert changes here and good to go.
on it. How do we bump the package version, manually via package json or is there a certain flow to follow? @gentlementlegen I saw you manually bumped it the commits so I done the same. |
Release please will automatically generate the changelogs based on the conventional commits, bump the version accordingly, and publish the package once all of these changes are merge into the main branch, so no need to do it manually. |
Right okay, so should I revert the manual bump I just committed or it doesn't matter because |
Correct, please revert the bump and the changelog changes. |
This reverts commit 49271cf.
So unless I redo the pull and fix the conventional commits the changelog won't change I expect since I used |
@Keyrxng It is also valid to name your PR with a conventional commit name, it should be picked up. I renamed, and yes moving forward it is always nicer to properly name the commits if they introduce fixes, features etc. |
That's a good feature and I know my commit habits are poor (but improving 😂) especially commit names, everything is a chore to me but I will do @gentlementlegen cheers |
@gentlementlegen happy to approve and merge this in so I can use it in |
@Keyrxng please fix this comment and good to go. |
The changes here are because of |
@Keyrxng It will be totally re-generated on next release so it doesn't really matter, but why not I guess. |
index.ts
export filetsup.config.ts
PrettyLogsWithOk