Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated exports for the logger #23

Merged
merged 8 commits into from
Jul 9, 2024

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Jul 5, 2024

  • adds a single index.ts export file
  • adds tsup.config.ts
  • improved naming convention for PrettyLogsWithOk
  • removes sourcemap from build
  • also exporting the util functions for cleaning logs which will be beneficial for when relying on these logs in tests

image

@Keyrxng Keyrxng requested a review from gentlementlegen July 5, 2024 10:44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are changes needed within the changelogs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first time updating a changelog, things look ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogs are automated by release-please so will be re-generated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keyrxng please revert changes here and good to go.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Jul 7, 2024

on it. How do we bump the package version, manually via package json or is there a certain flow to follow? @gentlementlegen

I saw you manually bumped it the commits so I done the same.

@gentlementlegen
Copy link
Member

Release please will automatically generate the changelogs based on the conventional commits, bump the version accordingly, and publish the package once all of these changes are merge into the main branch, so no need to do it manually.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Jul 7, 2024

Release please will automatically generate the changelogs based on the conventional commits, bump the version accordingly, and publish the package once all of these changes are merge into the main branch, so no need to do it manually.

Right okay, so should I revert the manual bump I just committed or it doesn't matter because release-please will handle it anyway?

@gentlementlegen
Copy link
Member

Correct, please revert the bump and the changelog changes.

This reverts commit 49271cf.
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Jul 7, 2024

Correct, please revert the bump and the changelog changes.

So unless I redo the pull and fix the conventional commits the changelog won't change I expect since I used chore: for each commit which seems to be ignored, if everything is automated that is. I will keep this in mind when committing to other npm packages going forward

@gentlementlegen
Copy link
Member

gentlementlegen commented Jul 7, 2024

@Keyrxng It is also valid to name your PR with a conventional commit name, it should be picked up.

I renamed, and yes moving forward it is always nicer to properly name the commits if they introduce fixes, features etc.

@gentlementlegen gentlementlegen changed the title Logger exports feat: updated exports for the logger Jul 7, 2024
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Jul 7, 2024

That's a good feature and I know my commit habits are poor (but improving 😂) especially commit names, everything is a chore to me but I will do @gentlementlegen cheers

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Jul 8, 2024

@gentlementlegen happy to approve and merge this in so I can use it in start-stop please?

@gentlementlegen
Copy link
Member

@Keyrxng please fix this comment and good to go.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Jul 9, 2024

@Keyrxng please fix this comment and good to go.

The changes here are because of prettier and are purely markdown syntax changes (same output). I can replace - with * and add CHANGELOG.md to .prettierignore?

@gentlementlegen
Copy link
Member

@Keyrxng It will be totally re-generated on next release so it doesn't really matter, but why not I guess.

@gentlementlegen gentlementlegen merged commit d18f3c8 into ubiquity-os:development Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants