-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/proxy callbacks #191
Feat/proxy callbacks #191
Conversation
@gentlementlegen @whilefoo Fancy a peak? Still to accommodate actions, fix failing tests and will do that tmrw but it's a matter of replicating the code pretty much (will try to avoid actually copy/pasting). Anything sticking out so far that's a deal breaker? Also am I correct in thinking the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed since we moved the SDK out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think it's fine but maybe you should remove all the SDK related code.
Makes sense to PR the SDK so I'll need to redo this PR |
ubiquity-os-marketplace/command-ask#26 (comment) If this PR is a priority can the task be priced and I'll be happy to re-do things (once the location of where the SDK will live is decided) |
Resolves ubiquity-os/plugin-sdk#33
CallbackBuilder
class to help build theproxyCallbacks
objectcreatePlugin
takesCallbackBuilder
instead ofhandler()
/sdk
and/types
right now but easy to add othersQA: ubq-testing/qa-plugin#1
Building callbacks:
Callback signature:
Clean package.json per dist dir: