Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable RLS for tables #22

Merged

Conversation

gentlementlegen
Copy link
Member

Added RLS security for tables to avoid having the data readable / writable by anyone.

@gentlementlegen gentlementlegen marked this pull request as ready for review September 30, 2024 05:41
@gentlementlegen
Copy link
Member Author

@sshivaditya2019 rfc

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this really matters much if the auth token is hidden.

@sshivaditya2019
Copy link
Collaborator

sshivaditya2019 commented Sep 30, 2024

@sshivaditya2019 rfc

Enabling RLS would require policies for managing DML operations. However, I think this may not be necessary since no one can write without the anon key/db pass, and reading should be fine since it's public text data.

@gentlementlegen
Copy link
Member Author

That's true, it is more to avoid Supabase warnings and updated the README with it as well.

README.md Show resolved Hide resolved
@0x4007 0x4007 merged commit 12a4725 into ubiquity-os-marketplace:development Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants